Make JSError conform to JSBridgedClass#86
Merged
MaxDesiatov merged 2 commits intoOct 1, 2020
mainswiftwasm/JavaScriptKit:mainfrom
jserror-jsvalueconstructibleswiftwasm/JavaScriptKit:jserror-jsvalueconstructibleCopy head branch name to clipboard
Merged
Make JSError conform to JSBridgedClass#86MaxDesiatov merged 2 commits intomainswiftwasm/JavaScriptKit:mainfrom jserror-jsvalueconstructibleswiftwasm/JavaScriptKit:jserror-jsvalueconstructibleCopy head branch name to clipboard
JSError conform to JSBridgedClass#86MaxDesiatov merged 2 commits into
mainswiftwasm/JavaScriptKit:mainfrom
jserror-jsvalueconstructibleswiftwasm/JavaScriptKit:jserror-jsvalueconstructibleCopy head branch name to clipboard
Conversation
The lack of this conformance makes it impossible to attach `catch` callbacks to `JSPromise`, as `catch` methods have `Failure: JSValueConstructible` constraints.
|
Time Change: +439.25ms (2%) Total Time: 15,722.75ms ℹ️ View Unchanged
|
Member
|
Does it make sense to make JSError a bridged class to the JavaScript Error class? |
kateinoigakukun
approved these changes
Sep 30, 2020
JSValueConstructible on JSErrorJSError conform to JSBridgedClass
j-f1
approved these changes
Oct 1, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The lack of this conformance makes it impossible to attach
catchcallbacks toJSPromisewhenFailure: JSError, ascatchmethods haveFailure: JSValueConstructibleconstraints.