Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Add missing .npmignore, bump version to 0.7.2#85

Merged
j-f1 merged 1 commit into
mainswiftwasm/JavaScriptKit:mainfrom
missing-npmignoreswiftwasm/JavaScriptKit:missing-npmignoreCopy head branch name to clipboard
Sep 28, 2020
Merged

Add missing .npmignore, bump version to 0.7.2#85
j-f1 merged 1 commit into
mainswiftwasm/JavaScriptKit:mainfrom
missing-npmignoreswiftwasm/JavaScriptKit:missing-npmignoreCopy head branch name to clipboard

Conversation

@MaxDesiatov

Copy link
Copy Markdown
Member

In 0.7.1 the runtime files are still not available through npm. The reason was this:

If there is a .gitignore file, and .npmignore is missing, .gitignore’s contents will be used instead.

The Runtime directory had .gitignore that mentioned the lib subdirectory with transpiled files. This made sense, but absence of .npmignore excluded these files from uploading.

@MaxDesiatov MaxDesiatov added the bug Something isn't working label Sep 28, 2020
@MaxDesiatov MaxDesiatov requested review from a team, j-f1 and kateinoigakukun and removed request for a team September 28, 2020 09:32
@github-actions

Copy link
Copy Markdown

Time Change: +238ms (1%)

Total Time: 13,734.25ms

ℹ️ View Unchanged
Test name Duration Change
Serialization/Write JavaScript number directly 174.75ms +4.25ms (2%)
Serialization/Write JavaScript string directly 176.75ms +1.25ms (0%)
Serialization/Swift Int to JavaScript 5,026ms +150ms (2%)
Serialization/Swift String to JavaScript 5,260.75ms +234ms (4%)
Object heap/Increment and decrement RC 3,096ms -151.5ms (4%)

performance-action

@j-f1 j-f1 merged commit 6e84a70 into main Sep 28, 2020
@j-f1 j-f1 deleted the missing-npmignore branch September 28, 2020 15:02
@j-f1

j-f1 commented Sep 28, 2020

Copy link
Copy Markdown
Member

The files are now present! https://unpkg.com/browse/javascript-kit-swift@0.7.2/Runtime/lib/

@MaxDesiatov

Copy link
Copy Markdown
Member Author

Awesome, thanks for tagging the release!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.