Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Fix runtime files location in package.json#81

Merged
MaxDesiatov merged 1 commit into
mainswiftwasm/JavaScriptKit:mainfrom
runtime-files-fixswiftwasm/JavaScriptKit:runtime-files-fixCopy head branch name to clipboard
Sep 26, 2020
Merged

Fix runtime files location in package.json#81
MaxDesiatov merged 1 commit into
mainswiftwasm/JavaScriptKit:mainfrom
runtime-files-fixswiftwasm/JavaScriptKit:runtime-files-fixCopy head branch name to clipboard

Conversation

@MaxDesiatov

@MaxDesiatov MaxDesiatov commented Sep 26, 2020

Copy link
Copy Markdown
Member

Resolves #79.

This requires tagging a new release and republishing on NPM to fully fix the issue.

@MaxDesiatov MaxDesiatov added the bug Something isn't working label Sep 26, 2020
@MaxDesiatov MaxDesiatov requested a review from a team September 26, 2020 17:33
@github-actions

Copy link
Copy Markdown

Time Change: +377ms (2%)

Total Time: 13,356.75ms

ℹ️ View Unchanged
Test name Duration Change
Serialization/Write JavaScript number directly 186.25ms +5.5ms (2%)
Serialization/Write JavaScript string directly 181ms -1.75ms (0%)
Serialization/Swift Int to JavaScript 4,843.25ms +110ms (2%)
Serialization/Swift String to JavaScript 4,960ms +118.25ms (2%)
Object heap/Increment and decrement RC 3,186.25ms +145ms (4%)

performance-action

@j-f1 j-f1 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yikes, thanks for fixing this!

@MaxDesiatov MaxDesiatov merged commit 317bab3 into main Sep 26, 2020
@MaxDesiatov MaxDesiatov deleted the runtime-files-fix branch September 26, 2020 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0.7.0 unavailable on NPM

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.