Run 4 perf tests instead of 2#80
Merged
Conversation
|
Time Change: -112.75ms (0%) Total Time: 14,525.25ms ℹ️ View Unchanged
|
MaxDesiatov
approved these changes
Sep 25, 2020
MaxDesiatov
left a comment
Member
There was a problem hiding this comment.
0% here is good. I guess we'll need to see it running on more PRs to understand if the variance is really lower with 4 runs instead of 2.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It looks like the perf test script is running in ~2m before this change, which leaves plenty of time to gather more samples to hopefully smooth out the results so perf changes can be better caught.
I changed it to run the perf tests four times, with 2 in parallel at once. The constants can be easily changed if we find it’s still not stable enough.