Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Revert "BridgeJS: Correctly emit @JS methods in extensions"#703

Merged
MaxDesiatov merged 1 commit into
mainswiftwasm/JavaScriptKit:mainfrom
revert-694-extensionsswiftwasm/JavaScriptKit:revert-694-extensionsCopy head branch name to clipboard
Mar 16, 2026
Merged

Revert "BridgeJS: Correctly emit @JS methods in extensions"#703
MaxDesiatov merged 1 commit into
mainswiftwasm/JavaScriptKit:mainfrom
revert-694-extensionsswiftwasm/JavaScriptKit:revert-694-extensionsCopy head branch name to clipboard

Conversation

@MaxDesiatov

@MaxDesiatov MaxDesiatov commented Mar 16, 2026

Copy link
Copy Markdown
Member

Revert of #694. Required to unblock CI on #702.

@MaxDesiatov MaxDesiatov added the bug Something isn't working label Mar 16, 2026
@MaxDesiatov MaxDesiatov merged commit abf1c88 into main Mar 16, 2026
12 checks passed
@MaxDesiatov MaxDesiatov deleted the revert-694-extensions branch March 16, 2026 21:56
kateinoigakukun pushed a commit that referenced this pull request Mar 24, 2026
* BridgeJS: Correctly emit @js methods in extensions

* BridgeJS: Improve test coverage for @js methods and properties in extensions

* Fix formatting

* Update test code to avoid accidentally introduced failure

* Fix CI: update snapshots, formatting, runtime test, add docs and review feedback

* BridgeJS: Regenerate snapshots and runtime bindings against current main

---------

Co-authored-by: William Taylor <git@will.au>
Co-authored-by: Max Desiatov <m_desiatov@apple.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Morty Proxy This is a proxified and sanitized view of the page, visit original site.