Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Add Prettier, reformat JS code#69

Merged
j-f1 merged 7 commits into
masterswiftwasm/JavaScriptKit:masterfrom
prettierswiftwasm/JavaScriptKit:prettierCopy head branch name to clipboard
Sep 24, 2020
Merged

Add Prettier, reformat JS code#69
j-f1 merged 7 commits into
masterswiftwasm/JavaScriptKit:masterfrom
prettierswiftwasm/JavaScriptKit:prettierCopy head branch name to clipboard

Conversation

@j-f1

@j-f1 j-f1 commented Sep 23, 2020

Copy link
Copy Markdown
Member

See #68 (comment). This introduces a bunch of changes so I wanted to pull it into a separate PR so we can bikeshed on options if necessary.

@MaxDesiatov

Copy link
Copy Markdown
Member

Could you also add .pre-commit-config.yml with a prettier snippet as described here, and we could add SwiftFormat and SwiftLint to it in future PRs?

@j-f1

j-f1 commented Sep 23, 2020

Copy link
Copy Markdown
Member Author

I’m trying but it’s not working ¯\_(ツ)_/¯

Screenshot_2020-09-23 19 43 30

it’s been like that for several minutes.

@MaxDesiatov MaxDesiatov left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 I'll try to add pre-commit in a separate PR

@j-f1

This comment has been minimized.

@j-f1 j-f1 merged commit 76bbe70 into master Sep 24, 2020
@j-f1 j-f1 deleted the prettier branch September 24, 2020 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.