Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Add property access tracing to JSTracing#687

Merged
kateinoigakukun merged 5 commits into
swiftwasm:mainswiftwasm/JavaScriptKit:mainfrom
gn-adin-b:adin/property-access-tracinggn-adin-b/JavaScriptKit:adin/property-access-tracingCopy head branch name to clipboard
Mar 3, 2026
Merged

Add property access tracing to JSTracing#687
kateinoigakukun merged 5 commits into
swiftwasm:mainswiftwasm/JavaScriptKit:mainfrom
gn-adin-b:adin/property-access-tracinggn-adin-b/JavaScriptKit:adin/property-access-tracingCopy head branch name to clipboard

Conversation

@gn-adin-b

Copy link
Copy Markdown
Contributor

Summary

  • Adds propertyGet/propertySet cases to JSCallInfo so property reads/writes on JSObject are traced
  • Instruments all 4 subscript pairs (String, JSString, Int, JSSymbol) with the beginJSCall/traceEnd pattern
  • Adds test for property access tracing and updates existing method test to filter by event type

Test plan

  • CI passes with --traits Tracing

@gn-adin-b

Copy link
Copy Markdown
Contributor Author

cc @kateinoigakukun

@kateinoigakukun kateinoigakukun left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to JavaScriptKit :)

@kateinoigakukun kateinoigakukun merged commit 5529520 into swiftwasm:main Mar 3, 2026
12 checks passed
wfltaylor pushed a commit to wfltaylor/JavaScriptKit that referenced this pull request Mar 10, 2026
…tracing

Add property access tracing to JSTracing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.