BridgeJS: Improve diagnostics and fix-its for macros#597
Merged
krodak merged 1 commit intoFeb 6, 2026
mainswiftwasm/JavaScriptKit:mainfrom
katei/b443-bridgejs-macrosswiftwasm/JavaScriptKit:katei/b443-bridgejs-macrosCopy head branch name to clipboard
Merged
BridgeJS: Improve diagnostics and fix-its for macros#597krodak merged 1 commit intomainswiftwasm/JavaScriptKit:mainfrom katei/b443-bridgejs-macrosswiftwasm/JavaScriptKit:katei/b443-bridgejs-macrosCopy head branch name to clipboard
krodak merged 1 commit into
mainswiftwasm/JavaScriptKit:mainfrom
katei/b443-bridgejs-macrosswiftwasm/JavaScriptKit:katei/b443-bridgejs-macrosCopy head branch name to clipboard
Conversation
Examples added/covered in this change:
- @JSFunction: enforce throws(JSException) (missing or wrong type) with note + fix-it ("Declare throws(JSException)").
- @JSFunction: instance members outside @jsclass emit a clear diagnostic.
- @JSGetter/@JSSetter: members (instance/static/class) outside @jsclass emit a clear diagnostic.
- @JSSetter: invalid setter names (e.g. updateFoo) emit a diagnostic and suggest a rename fix-it (e.g. setFoo).
- @JSSetter: missing value parameter emits a diagnostic and suggests adding a placeholder parameter.
- @jsclass: using @jsclass on non-struct declarations emits a diagnostic; for "class" also suggests "Change 'class' to 'struct'".
krodak
approved these changes
Feb 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Examples added/covered in this change: