Add ts2swift Record to Dictionary mapping#582
Merged
kateinoigakukun merged 1 commit intoFeb 5, 2026
mainswiftwasm/JavaScriptKit:mainfrom
katei/3cb0-please-add-recorswiftwasm/JavaScriptKit:katei/3cb0-please-add-recorCopy head branch name to clipboard
Merged
Add ts2swift Record to Dictionary mapping#582kateinoigakukun merged 1 commit intomainswiftwasm/JavaScriptKit:mainfrom katei/3cb0-please-add-recorswiftwasm/JavaScriptKit:katei/3cb0-please-add-recorCopy head branch name to clipboard
kateinoigakukun merged 1 commit into
mainswiftwasm/JavaScriptKit:mainfrom
katei/3cb0-please-add-recorswiftwasm/JavaScriptKit:katei/3cb0-please-add-recorCopy head branch name to clipboard
Conversation
krodak
approved these changes
Feb 5, 2026
ee19ac2 to
aa82380
Compare
…ript/src/processor.js`, mapping `Record<string, T>` to `[String: T]` (with JSObject fallback for non-string keys) by reading alias type arguments even when the type isn’t a `TypeReference`. - Added a new fixture and refreshed Vitest snapshots to cover dictionary outputs, nested/optional records, array/object values, and unsupported key handling in `Plugins/BridgeJS/Sources/TS2Swift/JavaScript/test/fixtures/RecordDictionary.d.ts` and `.../__snapshots__/ts2swift.test.js.snap`. Tests: `cd Plugins/BridgeJS/Sources/TS2Swift/JavaScript && npm test -- --update`.
228b50f to
25683e4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation:
Record<string, T>outputs.Changes:
Record<string, T>(including alias instantiations) to[String: T]with a warning fallback for non-string keys.