Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Remove JavaScriptTypedArrayKind#58

Merged
kateinoigakukun merged 3 commits into
masterswiftwasm/JavaScriptKit:masterfrom
typed-array-updateswiftwasm/JavaScriptKit:typed-array-updateCopy head branch name to clipboard
Sep 16, 2020
Merged

Remove JavaScriptTypedArrayKind#58
kateinoigakukun merged 3 commits into
masterswiftwasm/JavaScriptKit:masterfrom
typed-array-updateswiftwasm/JavaScriptKit:typed-array-updateCopy head branch name to clipboard

Conversation

@j-f1

@j-f1 j-f1 commented Sep 16, 2020

Copy link
Copy Markdown
Member

Fixes #52.

@j-f1

j-f1 commented Sep 16, 2020

Copy link
Copy Markdown
Member Author

Reading through #57 reminded me that I did not bump the library version in #31. Is this an issue? Also, what’s the standard for how much to increment the version?

@kateinoigakukun

Copy link
Copy Markdown
Member

I did not bump the library version in #31. Is this an issue?

This is not a big issue because I bumped the version before releasing 0.6.0.

Also, what’s the standard for how much to increment the version?

At least it's ok if it's greater than the old value.

@kateinoigakukun kateinoigakukun merged commit 6652885 into master Sep 16, 2020
@kateinoigakukun kateinoigakukun deleted the typed-array-update branch September 16, 2020 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TypedArray improvement?

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.