Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Add doc comments for public APIs (Part 1)#55

Merged
kateinoigakukun merged 3 commits into
masterswiftwasm/JavaScriptKit:masterfrom
add-doc-commentsswiftwasm/JavaScriptKit:add-doc-commentsCopy head branch name to clipboard
Sep 16, 2020
Merged

Add doc comments for public APIs (Part 1)#55
kateinoigakukun merged 3 commits into
masterswiftwasm/JavaScriptKit:masterfrom
add-doc-commentsswiftwasm/JavaScriptKit:add-doc-commentsCopy head branch name to clipboard

Conversation

@kateinoigakukun

Copy link
Copy Markdown
Member

No description provided.

Comment thread Sources/JavaScriptKit/FundamentalObjects/JSFunction.swift Outdated
Comment thread Sources/JavaScriptKit/FundamentalObjects/JSObject.swift Outdated

@MaxDesiatov MaxDesiatov left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is amazing, thank you so much 👏 Just a couple of suggestions

kateinoigakukun and others added 2 commits September 16, 2020 20:19
Co-authored-by: Max Desiatov <max@desiatov.com>
Co-authored-by: Max Desiatov <max@desiatov.com>
@kateinoigakukun

Copy link
Copy Markdown
Member Author

Thanks for wording suggestions 😄

@kateinoigakukun kateinoigakukun merged commit 2eade6f into master Sep 16, 2020
@kateinoigakukun kateinoigakukun deleted the add-doc-comments branch September 16, 2020 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.