BridgeJS: allow exported APIs to use imported @JSClass types#522
Merged
krodak merged 1 commit intoJan 26, 2026
mainswiftwasm/JavaScriptKit:mainfrom
bridgejs-imported-ts-type-export-interfaceswiftwasm/JavaScriptKit:bridgejs-imported-ts-type-export-interfaceCopy head branch name to clipboard
Merged
BridgeJS: allow exported APIs to use imported @JSClass types#522krodak merged 1 commit intomainswiftwasm/JavaScriptKit:mainfrom bridgejs-imported-ts-type-export-interfaceswiftwasm/JavaScriptKit:bridgejs-imported-ts-type-export-interfaceCopy head branch name to clipboard
krodak merged 1 commit into
mainswiftwasm/JavaScriptKit:mainfrom
bridgejs-imported-ts-type-export-interfaceswiftwasm/JavaScriptKit:bridgejs-imported-ts-type-export-interfaceCopy head branch name to clipboard
Conversation
…s in exported APIs by treating `@JSClass` **classes/actors** as `.jsObject` (previously they were misclassified as Swift heap objects, producing JS like `Foo.__construct(...)`). - Fix: `Plugins/BridgeJS/Sources/BridgeJSCore/SwiftToSkeleton.swift` - Regression test + snapshots: `Plugins/BridgeJS/Tests/BridgeJSToolTests/Inputs/ImportedTypeInExportedInterface.swift`, `Plugins/BridgeJS/Tests/BridgeJSToolTests/__Snapshots__/BridgeJSLinkTests/ImportedTypeInExportedInterface.Export.js`, `Plugins/BridgeJS/Tests/BridgeJSToolTests/__Snapshots__/BridgeJSLinkTests/ImportedTypeInExportedInterface.Export.d.ts`, `Plugins/BridgeJS/Tests/BridgeJSToolTests/__Snapshots__/ExportSwiftTests/ImportedTypeInExportedInterface.swift`, `Plugins/BridgeJS/Tests/BridgeJSToolTests/__Snapshots__/ExportSwiftTests/ImportedTypeInExportedInterface.json` - Verified with `swift test --package-path ./Plugins/BridgeJS`
bbaa0a5 to
d9d6c56
Compare
krodak
approved these changes
Jan 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #497.
@JSClassdeclarations written asclass/actoras JS object wrapper types when they appear in exported signatures.