BridgeJS: Fix ordering issue with multiple stack based parameters#472
Merged
krodak merged 2 commits intoNov 28, 2025
swiftwasm:mainswiftwasm/JavaScriptKit:mainfrom
PassiveLogic:fix/multiple-stack-based-parametersPassiveLogic/JavaScriptKit:fix/multiple-stack-based-parametersCopy head branch name to clipboard
Merged
BridgeJS: Fix ordering issue with multiple stack based parameters#472krodak merged 2 commits intoswiftwasm:mainswiftwasm/JavaScriptKit:mainfrom PassiveLogic:fix/multiple-stack-based-parametersPassiveLogic/JavaScriptKit:fix/multiple-stack-based-parametersCopy head branch name to clipboard
krodak merged 2 commits into
swiftwasm:mainswiftwasm/JavaScriptKit:mainfrom
PassiveLogic:fix/multiple-stack-based-parametersPassiveLogic/JavaScriptKit:fix/multiple-stack-based-parametersCopy head branch name to clipboard
Conversation
… reversed order and intermediate properties
kateinoigakukun
approved these changes
Nov 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
While working on struct implementation, I've noticed that we don't properly inverse order when lifting stack-based types parameters in Swift glue code.
Issue can be seen in 15974c72250981e55bef095ee6586fde71675853
And is fixed in next commit, proper end to end test is added as well