Fix empty TypedArray creation#278
Merged
kateinoigakukun merged 1 commit intoDec 8, 2024
mainswiftwasm/JavaScriptKit:mainfrom
katei/fix-empty-typed-arrayswiftwasm/JavaScriptKit:katei/fix-empty-typed-arrayCopy head branch name to clipboard
Merged
Fix empty TypedArray creation#278kateinoigakukun merged 1 commit intomainswiftwasm/JavaScriptKit:mainfrom katei/fix-empty-typed-arrayswiftwasm/JavaScriptKit:katei/fix-empty-typed-arrayCopy head branch name to clipboard
kateinoigakukun merged 1 commit into
mainswiftwasm/JavaScriptKit:mainfrom
katei/fix-empty-typed-arrayswiftwasm/JavaScriptKit:katei/fix-empty-typed-arrayCopy head branch name to clipboard
Conversation
|
Time Change: +260ms (2%) Total Time: 9,837ms
View Unchanged
View Baselines
|
|
Thank you for this change! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close swiftwasm/swift#5599
Empty array instances share the same storage for all element types, so their
baseAddresscan be unaligned. (It seems the empty array storage had been placed at 8-aligned position fortunately but it's no longer the case since Swift 6.0, I guess)https://github.com/swiftlang/swift/blob/2914d0e46eda33cadfd81c3381e8737855ce397c/stdlib/public/stubs/GlobalObjects.cpp#L42