Expose JavaScriptEventLoop.queueMicrotask and .setTimeout#214
Merged
kateinoigakukun merged 1 commit intoOct 3, 2022
mainswiftwasm/JavaScriptKit:mainfrom
katei/expose-hook-pointsswiftwasm/JavaScriptKit:katei/expose-hook-pointsCopy head branch name to clipboard
Merged
Expose JavaScriptEventLoop.queueMicrotask and .setTimeout#214kateinoigakukun merged 1 commit intomainswiftwasm/JavaScriptKit:mainfrom katei/expose-hook-pointsswiftwasm/JavaScriptKit:katei/expose-hook-pointsCopy head branch name to clipboard
JavaScriptEventLoop.queueMicrotask and .setTimeout#214kateinoigakukun merged 1 commit into
mainswiftwasm/JavaScriptKit:mainfrom
katei/expose-hook-pointsswiftwasm/JavaScriptKit:katei/expose-hook-pointsCopy head branch name to clipboard
Conversation
This allows users to have more flexibility to customize.
For example, this allows inserting operations before/after single job
execution loop.
e.g. It's useful to enable React batch rendering per job execution loop
by `ReactDOM.unstable_batchedUpdates`.
```swift
let original = JavaScriptEventLoop.shared.queueMicrotask
JavaScriptEventLoop.shared.queueMicrotask = (job) => {
ReactDOM.unstable_batchedUpdates(() => {
original(job)
})
}
```
|
Time Change: -141ms (0%) Total Time: 18,740ms
View Unchanged
View Baselines
|
j-f1
approved these changes
Oct 3, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows users to have more flexibility to customize. For example, this allows inserting operations before/after single job execution loop.
e.g. It's useful to enable React batch rendering per job execution loop by
ReactDOM.unstable_batchedUpdates.