Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Add diagnostics for those who build with WASI command line ABI#202

Merged
kateinoigakukun merged 1 commit into
mainswiftwasm/JavaScriptKit:mainfrom
katei/diagnose-wasi-command-lineswiftwasm/JavaScriptKit:katei/diagnose-wasi-command-lineCopy head branch name to clipboard
Jul 31, 2022
Merged

Add diagnostics for those who build with WASI command line ABI#202
kateinoigakukun merged 1 commit into
mainswiftwasm/JavaScriptKit:mainfrom
katei/diagnose-wasi-command-lineswiftwasm/JavaScriptKit:katei/diagnose-wasi-command-lineCopy head branch name to clipboard

Conversation

@kateinoigakukun

@kateinoigakukun kateinoigakukun commented Jul 31, 2022

Copy link
Copy Markdown
Member

It's hard to find the root cause of crash when building with WASI command ABI

Mitigate unfortunate situations like #199

@kateinoigakukun kateinoigakukun force-pushed the katei/diagnose-wasi-command-line branch from 35005ef to 2885304 Compare July 31, 2022 14:52
@github-actions

github-actions Bot commented Jul 31, 2022

Copy link
Copy Markdown

Time Change: -706ms (3%)

Total Time: 20,340ms

Test name Duration Change
Serialization/Write JavaScript string directly 452ms -32ms (7%)
View Unchanged
Test name Duration Change
Serialization/Write JavaScript number directly 436ms +1ms
Serialization/Swift Int to JavaScript 6,668ms -216ms (3%)
Serialization/Swift String to JavaScript 6,679ms -182ms (2%)
Object heap/Increment and decrement RC 6,105ms -278ms (4%)

@kateinoigakukun kateinoigakukun requested a review from a team July 31, 2022 15:04

@MaxDesiatov MaxDesiatov left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kateinoigakukun kateinoigakukun merged commit 8478665 into main Jul 31, 2022
@kateinoigakukun kateinoigakukun deleted the katei/diagnose-wasi-command-line branch July 31, 2022 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.