Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Add async JSPromise.result property#200

Merged
kateinoigakukun merged 1 commit into
mainswiftwasm/JavaScriptKit:mainfrom
katei/jspromise-resultswiftwasm/JavaScriptKit:katei/jspromise-resultCopy head branch name to clipboard
Jul 19, 2022
Merged

Add async JSPromise.result property#200
kateinoigakukun merged 1 commit into
mainswiftwasm/JavaScriptKit:mainfrom
katei/jspromise-resultswiftwasm/JavaScriptKit:katei/jspromise-resultCopy head branch name to clipboard

Conversation

@kateinoigakukun

@kateinoigakukun kateinoigakukun commented Jul 19, 2022 •
edited
Loading

Copy link
Copy Markdown
Member

Add JSPromise.result, which is similar with Task.result

@kateinoigakukun kateinoigakukun requested a review from a team July 19, 2022 06:57
@github-actions

github-actions Bot commented Jul 19, 2022

Copy link
Copy Markdown

Time Change: -172ms (0%)

Total Time: 17,509ms

Test name Duration Change
Serialization/Write JavaScript number directly 391ms -44ms (11%) 👏
Serialization/Write JavaScript string directly 436ms -41ms (9%) ✅
View Unchanged
Test name Duration Change
Serialization/Swift Int to JavaScript 5,535ms -63ms (1%)
Serialization/Swift String to JavaScript 5,718ms -62ms (1%)
Object heap/Increment and decrement RC 5,430ms +38ms (0%)

yonihemi
yonihemi reviewed Jul 19, 2022
View reviewed changes
Comment thread Sources/JavaScriptEventLoop/JavaScriptEventLoop.swift
MaxDesiatov
MaxDesiatov approved these changes Jul 19, 2022
View reviewed changes

@MaxDesiatov MaxDesiatov left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kateinoigakukun kateinoigakukun merged commit 901de66 into main Jul 19, 2022
@kateinoigakukun kateinoigakukun deleted the katei/jspromise-result branch July 19, 2022 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MaxDesiatov MaxDesiatov MaxDesiatov approved these changes

@yonihemi yonihemi yonihemi approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kateinoigakukun @MaxDesiatov @yonihemi
Morty Proxy This is a proxified and sanitized view of the page, visit original site.