Supply JSKit runtime in SwiftPM resources#193
Merged
MaxDesiatov merged 12 commits intoMay 12, 2022
mainswiftwasm/JavaScriptKit:mainfrom
maxd/runtime-resourcesswiftwasm/JavaScriptKit:maxd/runtime-resourcesCopy head branch name to clipboard
Merged
Supply JSKit runtime in SwiftPM resources#193MaxDesiatov merged 12 commits intomainswiftwasm/JavaScriptKit:mainfrom maxd/runtime-resourcesswiftwasm/JavaScriptKit:maxd/runtime-resourcesCopy head branch name to clipboard
MaxDesiatov merged 12 commits into
mainswiftwasm/JavaScriptKit:mainfrom
maxd/runtime-resourcesswiftwasm/JavaScriptKit:maxd/runtime-resourcesCopy head branch name to clipboard
Conversation
|
Time Change: -311ms (1%) Total Time: 15,647ms View Unchanged
|
Member
There was a problem hiding this comment.
Could you add linguist-generated entry in .gitattributes to ignore the generated file from stats.
Also, could we have a script to update index.{js,mjs} in Makefile and check that they are up-to-date in CI?
j-f1
approved these changes
May 12, 2022
Co-authored-by: Yuta Saito <kateinoigakukun@gmail.com>
Co-authored-by: Yuta Saito <kateinoigakukun@gmail.com>
kateinoigakukun
approved these changes
May 12, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Due to the fact that swiftlang/swift-package-manager#4306 will only be available starting with Swift 5.7, we can't generate these resources with a SwiftPM plugin. I propose storing the generated code in the repository directly for now. When 5.7 is released, we can switch to a SwiftPM plugin approach.
Can be tested end-to-end with swiftwasm/carton#335.