Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Remove outdated BigInt support FIXME from JSTypedArray#187

Merged
MaxDesiatov merged 1 commit into
mainswiftwasm/JavaScriptKit:mainfrom
maxd/outdated-fixmeswiftwasm/JavaScriptKit:maxd/outdated-fixmeCopy head branch name to clipboard
May 2, 2022
Merged

Remove outdated BigInt support FIXME from JSTypedArray#187
MaxDesiatov merged 1 commit into
mainswiftwasm/JavaScriptKit:mainfrom
maxd/outdated-fixmeswiftwasm/JavaScriptKit:maxd/outdated-fixmeCopy head branch name to clipboard

Conversation

@MaxDesiatov

@MaxDesiatov MaxDesiatov commented May 2, 2022

Copy link
Copy Markdown
Member

The linked issue has already been closed, so this comment doesn't seem to be relevant.

The link issue has already been closed, so this comment doesn't seem to be relevant.
@MaxDesiatov MaxDesiatov added the documentation Improvements or additions to documentation label May 2, 2022
@MaxDesiatov MaxDesiatov requested a review from a team May 2, 2022 13:06
@github-actions

github-actions Bot commented May 2, 2022

Copy link
Copy Markdown

Time Change: +571ms (3%)

Total Time: 17,767ms

Test name Duration Change
Object heap/Increment and decrement RC 5,357ms +416ms (7%) 🔍
View Unchanged
Test name Duration Change
Serialization/Write JavaScript number directly 392ms +15ms (3%)
Serialization/Write JavaScript string directly 428ms +12ms (2%)
Serialization/Swift Int to JavaScript 5,742ms +59ms (1%)
Serialization/Swift String to JavaScript 5,848ms +68ms (1%)

@MaxDesiatov MaxDesiatov merged commit e858322 into main May 2, 2022
@MaxDesiatov MaxDesiatov deleted the maxd/outdated-fixme branch May 2, 2022 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.