Fix JSValueDecoder#185
Merged
j-f1 merged 2 commits intoApr 9, 2022
mainswiftwasm/JavaScriptKit:mainfrom
jed/fix-jsvaluedecoderswiftwasm/JavaScriptKit:jed/fix-jsvaluedecoderCopy head branch name to clipboard
Merged
Fix JSValueDecoder#185j-f1 merged 2 commits intomainswiftwasm/JavaScriptKit:mainfrom jed/fix-jsvaluedecoderswiftwasm/JavaScriptKit:jed/fix-jsvaluedecoderCopy head branch name to clipboard
j-f1 merged 2 commits into
mainswiftwasm/JavaScriptKit:mainfrom
jed/fix-jsvaluedecoderswiftwasm/JavaScriptKit:jed/fix-jsvaluedecoderCopy head branch name to clipboard
Conversation
|
Time Change: +603.25ms (6%) 🔍 Total Time: 9,693.75ms
ℹ️ View Unchanged
|
MaxDesiatov
approved these changes
Apr 9, 2022
MaxDesiatov
left a comment
Member
There was a problem hiding this comment.
Nice catch! Didn't we have an open issue for this somewhere, or am I misremembering?
Member
Author
|
Not that I know of, although there is #116 for implementing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We didn’t have any tests exercising this code, and as far as I can tell it has never worked.