Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Fix deprecation warning in JSFunction.swift#182

Merged
MaxDesiatov merged 1 commit into
mainswiftwasm/JavaScriptKit:mainfrom
maxd/jsvalue-deprecationswiftwasm/JavaScriptKit:maxd/jsvalue-deprecationCopy head branch name to clipboard
Apr 8, 2022
Merged

Fix deprecation warning in JSFunction.swift#182
MaxDesiatov merged 1 commit into
mainswiftwasm/JavaScriptKit:mainfrom
maxd/jsvalue-deprecationswiftwasm/JavaScriptKit:maxd/jsvalue-deprecationCopy head branch name to clipboard

Conversation

@MaxDesiatov

Copy link
Copy Markdown
Member

No description provided.

@github-actions

github-actions Bot commented Apr 8, 2022

Copy link
Copy Markdown

Time Change: +982ms (10%) ⚠️

Total Time: 9,713ms

Test name Duration Change
Serialization/Write JavaScript string directly 193.25ms -11.25ms (5%)
Serialization/Swift Int to JavaScript 2,882ms +228.75ms (7%) 🔍
Serialization/Swift String to JavaScript 3,365.75ms +628.25ms (18%) ⚠️
ℹ️ View Unchanged
Test name Duration Change
Serialization/Write JavaScript number directly 192.25ms -5.75ms (2%)
Object heap/Increment and decrement RC 3,079.75ms +142ms (4%)

performance-action

@MaxDesiatov MaxDesiatov marked this pull request as ready for review April 8, 2022 11:41
@MaxDesiatov MaxDesiatov requested a review from a team April 8, 2022 11:41

@j-f1 j-f1 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MaxDesiatov MaxDesiatov merged commit ca19e88 into main Apr 8, 2022
@MaxDesiatov MaxDesiatov deleted the maxd/jsvalue-deprecation branch April 8, 2022 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.