Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Bump version to 0.14.0, update CHANGELOG.md#181

Merged
MaxDesiatov merged 1 commit into
mainswiftwasm/JavaScriptKit:mainfrom
v0.14.0swiftwasm/JavaScriptKit:v0.14.0Copy head branch name to clipboard
Apr 8, 2022
Merged

Bump version to 0.14.0, update CHANGELOG.md#181
MaxDesiatov merged 1 commit into
mainswiftwasm/JavaScriptKit:mainfrom
v0.14.0swiftwasm/JavaScriptKit:v0.14.0Copy head branch name to clipboard

Conversation

@MaxDesiatov

@MaxDesiatov MaxDesiatov commented Apr 8, 2022 •
edited
Loading

Copy link
Copy Markdown
Member

New release is required to resolve TokamakUI/Tokamak#475.

I've also cleaned up formatting in .ts file and clarified version incompatibility error message.

@MaxDesiatov MaxDesiatov requested a review from a team April 8, 2022 08:39
@MaxDesiatov MaxDesiatov added documentation Improvements or additions to documentation dependencies Pull requests that update a dependency file labels Apr 8, 2022
@MaxDesiatov MaxDesiatov enabled auto-merge (squash) April 8, 2022 08:40
@MaxDesiatov MaxDesiatov merged commit 9a3b7d5 into main Apr 8, 2022
@MaxDesiatov MaxDesiatov deleted the v0.14.0 branch April 8, 2022 08:42
@github-actions

github-actions Bot commented Apr 8, 2022

Copy link
Copy Markdown

Time Change: +1,152.5ms (10%) ⚠️

Total Time: 11,165ms

Test name Duration Change
Serialization/Swift Int to JavaScript 3,350.5ms +277.25ms (8%) 🔍
Serialization/Swift String to JavaScript 3,923.75ms +893.25ms (22%) 🚨
ℹ️ View Unchanged
Test name Duration Change
Serialization/Write JavaScript number directly 220ms +2.5ms (1%)
Serialization/Write JavaScript string directly 221ms 0ms
Object heap/Increment and decrement RC 3,449.75ms -20.5ms (0%)

performance-action

@kateinoigakukun

kateinoigakukun commented Apr 8, 2022 •
edited
Loading

Copy link
Copy Markdown
Member

BTW I think this new release is not required for the Tokamak PR. Is there any essential change?

@MaxDesiatov

MaxDesiatov commented Apr 8, 2022 •
edited
Loading

Copy link
Copy Markdown
Member Author

swiftwasm/carton#310 relies on reactor model, which was updated in #180, wasn't it? And then .jsValue() -> .jsValue change was breaking, I'd like to update Tokamak codebase for it sooner rather than later.

Either way, I've already tagged it, sorry if that was premature 😅

@kateinoigakukun

kateinoigakukun commented Apr 8, 2022

Copy link
Copy Markdown
Member

#180 is only for test harnesses, so no change in the js runtime. Yeah, it's fine to release breaking changes soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kateinoigakukun kateinoigakukun kateinoigakukun approved these changes

Assignees

No one assigned

Labels

dependencies Pull requests that update a dependency file documentation Improvements or additions to documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@MaxDesiatov @kateinoigakukun
Morty Proxy This is a proxified and sanitized view of the page, visit original site.