Improve error messages when JS code throws exceptions#173

Merged

kateinoigakukun merged 7 commits into

swiftwasm:mainfrom

GoodNotes:do-not-catch-js-exceptions-in-js-function

Mar 31, 2022

Commits on Mar 30, 2022

Remove a not neede try/catch when evaluating JSFunction values so we can improve error reporting by not hiding the information we get form the JS crash
pedrovgs
committed
ff490e9
Copy full SHA for ff490e9
Modify JSThrowingFunction to be based on the safe version of _call_function_with_this and _call_function instead of the unsafe version we created
pedrovgs
committed
35d4c92
Copy full SHA for 35d4c92
Update swjs_call_function_unsafe to notify wasm when there is an exception
Show description for f5072a5

pedrovgs
and
j-f1
authored
f5072a5
Copy full SHA for f5072a5
Modify swjs_call_function_with_this_unsafe to notify WASM there was an exception as Jed suggested
pedrovgs
committed
160acf7
Copy full SHA for 160acf7
Recover the already written test cases for JSThrowingFunction and create a new test case for the new functionality
pedrovgs
committed
baa6678
Copy full SHA for baa6678

Commits on Mar 31, 2022

Rename unsafe fuctions to no_catch and simplify invokeNonThrowingJSFunction implementation
pedrovgs
committed
d7e8747
Copy full SHA for d7e8747
Bump swjs_library_version version
pedrovgs
committed
292b9db
Copy full SHA for 292b9db