Split runtime into multiple files#150
Merged
j-f1 merged 22 commits intoJan 24, 2022
mainswiftwasm/JavaScriptKit:mainfrom
jed/runtime-js-modulesswiftwasm/JavaScriptKit:jed/runtime-js-modulesCopy head branch name to clipboard
Merged
Split runtime into multiple files#150j-f1 merged 22 commits intomainswiftwasm/JavaScriptKit:mainfrom jed/runtime-js-modulesswiftwasm/JavaScriptKit:jed/runtime-js-modulesCopy head branch name to clipboard
j-f1 merged 22 commits into
mainswiftwasm/JavaScriptKit:mainfrom
jed/runtime-js-modulesswiftwasm/JavaScriptKit:jed/runtime-js-modulesCopy head branch name to clipboard
Conversation
|
Time Change: -307ms (3%) Total Time: 8,905.5ms
ℹ️ View Unchanged
|
Member
|
Some tests are failing 👀 Error in Literal Conversion
MessageError(message: "Expect to be equal \"212205744152385\" and \"4746794007244308480\"", file: "/home/runner/work/JavaScriptKit/JavaScriptKit/IntegrationTests/TestSuites/Sources/PrimaryTests/main.swift", line: 26, column: 28)
Swift/ErrorType.swift:200: Fatal error: Error raised at top level: PrimaryTests.MessageError(message: "Expect to be equal \"212205744152385\" and \"4746794007244308480\"", file: "/home/runner/work/JavaScriptKit/JavaScriptKit/IntegrationTests/TestSuites/Sources/PrimaryTests/main.swift", line: 26, column: 28)
RuntimeError: unreachable
at $ss17_assertionFailure__4file4line5flagss5NeverOs12StaticStringV_SSAHSus6UInt32VtF (wasm://wasm/02991d2a:wasm-function[2633]:0xccfd3)
at swift_errorInMain (wasm://wasm/02991d2a:wasm-function[4819]:0x14b4ac)
at main (wasm://wasm/02991d2a:wasm-function[1532]:0x76025)
at main (wasm://wasm/02991d2a:wasm-function[29674]:0x622f25)
at __main_void (wasm://wasm/02991d2a:wasm-function[29675]:0x622fa1)
at __original_main (wasm://wasm/02991d2a:wasm-function[29672]:0x622ee6)
at _start (wasm://wasm/02991d2a:wasm-function[45]:0x10884)
at d.start (/home/runner/work/JavaScriptKit/JavaScriptKit/IntegrationTests/node_modules/@wasmer/wasi/lib/index.cjs.js:77:280)
at startWasiTask (/home/runner/work/JavaScriptKit/JavaScriptKit/IntegrationTests/lib.js:47:10) |
Member
Author
|
It turned out to be an endianness issue, oof. Hoping this change fixes it 🤞 |
MaxDesiatov
reviewed
Jan 24, 2022
MaxDesiatov
reviewed
Jan 24, 2022
MaxDesiatov
approved these changes
Jan 24, 2022
MaxDesiatov
left a comment
Member
There was a problem hiding this comment.
Overall seems legit 👍 but I'd wait for at least one more approval from the team
kateinoigakukun
approved these changes
Jan 24, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR:
require, or by embedding it with a<script>tag and usingwindow.JavaScriptKitMemoryclass that provides easy access to memory and the heapSwiftClosureDeallocatorconstructor rather than outside of it