Fix recursion in TypedArray initializer#142
Merged
Merged
Fix recursion in TypedArray initializer#142
Conversation
MaxDesiatov
requested changes
Nov 9, 2021
MaxDesiatov
left a comment
Member
There was a problem hiding this comment.
Thanks, great catch! Would you be able to add a test that covers this?
MaxDesiatov
approved these changes
Nov 21, 2021
MaxDesiatov
left a comment
Member
There was a problem hiding this comment.
I've added a simple test, which I hope is enough, but let me know it doesn't reflect the code you've used to reproduce this on your side.
Contributor
Author
|
@MaxDesiatov that looks good! Sorry I didn't get to this earlier had been really busy. |
Member
|
No problem, thanks again for the PR! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The original unconstrained version would cause infinite recursion.