Experimental global executor cooperating with JS event loop#141
Merged
kateinoigakukun merged 6 commits intoOct 3, 2021
mainswiftwasm/JavaScriptKit:mainfrom
katei/js-serial-executorswiftwasm/JavaScriptKit:katei/js-serial-executorCopy head branch name to clipboard
Merged
Experimental global executor cooperating with JS event loop#141kateinoigakukun merged 6 commits intomainswiftwasm/JavaScriptKit:mainfrom katei/js-serial-executorswiftwasm/JavaScriptKit:katei/js-serial-executorCopy head branch name to clipboard
kateinoigakukun merged 6 commits into
mainswiftwasm/JavaScriptKit:mainfrom
katei/js-serial-executorswiftwasm/JavaScriptKit:katei/js-serial-executorCopy head branch name to clipboard
Conversation
|
Time Change: -149.25ms (1%) Total Time: 10,253.5ms
ℹ️ View Unchanged
|
MaxDesiatov
approved these changes
Oct 3, 2021
MaxDesiatov
left a comment
Member
There was a problem hiding this comment.
LGTM! Just a small comment typo nit
d1814e1 to
35aa907
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a replacement of #137 to follow the latest implementation of Concurrency runtime.
Task.sleep(nanoseconds:)causes a crash after resuming swift#3646 (maybe also optional for now? because it's the toolchain side issue)