Gardening tests#133
Merged
kateinoigakukun merged 7 commits intoJul 18, 2021
mainswiftwasm/JavaScriptKit:mainfrom
katei/gardening-testsswiftwasm/JavaScriptKit:katei/gardening-testsCopy head branch name to clipboard
Merged
Gardening tests#133kateinoigakukun merged 7 commits intomainswiftwasm/JavaScriptKit:mainfrom katei/gardening-testsswiftwasm/JavaScriptKit:katei/gardening-testsCopy head branch name to clipboard
kateinoigakukun merged 7 commits into
mainswiftwasm/JavaScriptKit:mainfrom
katei/gardening-testsswiftwasm/JavaScriptKit:katei/gardening-testsCopy head branch name to clipboard
Conversation
|
Time Change: +157.75ms (1%) Total Time: 10,526ms ℹ️ View Unchanged
|
MaxDesiatov
reviewed
Jul 18, 2021
| c1.release() | ||
| // Call a released closure | ||
| print("======= BEGIN OF EXPECTED FATAL ERROR =====") | ||
| _ = try expectThrow(try evalClosure.throws(c1)) |
Member
There was a problem hiding this comment.
Should expectThrow contain these prints to avoid repetition?
Member
Author
There was a problem hiding this comment.
expectThrow is not for crash tests, so I added another helper function
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
make testcrashes due toJSClosurememory issues #129 because it's an expected crash output