Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Fix branch and triple in compatibility.yml#105

Merged
MaxDesiatov merged 1 commit into
mainswiftwasm/JavaScriptKit:mainfrom
fix-branch-tripleswiftwasm/JavaScriptKit:fix-branch-tripleCopy head branch name to clipboard
Oct 26, 2020
Merged

Fix branch and triple in compatibility.yml#105
MaxDesiatov merged 1 commit into
mainswiftwasm/JavaScriptKit:mainfrom
fix-branch-tripleswiftwasm/JavaScriptKit:fix-branch-tripleCopy head branch name to clipboard

Conversation

@MaxDesiatov

Copy link
Copy Markdown
Member

master doesn't exist in our repository, so the workflow wasn't triggered. Also, the triple option had a typo, not sure how that even worked 🤔

`master` doesn't exist in our repository, so the workflow wasn't triggered. Also, the triple option had a typo, not sure how that even worked 🤔
@MaxDesiatov MaxDesiatov requested a review from a team October 26, 2020 09:55

@kateinoigakukun kateinoigakukun left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, thanks 😭

@github-actions

Copy link
Copy Markdown

Time Change: +1,180.75ms (10%) ⚠️

Total Time: 10,944.5ms

Test name Duration Change
Serialization/Swift Int to JavaScript 3,574.75ms +379.75ms (10%) ⚠️
Serialization/Swift String to JavaScript 3,570.75ms +316.5ms (8%) 🔍
Object heap/Increment and decrement RC 3,417.25ms +473.5ms (13%) ⚠️
ℹ️ View Unchanged
Test name Duration Change
Serialization/Write JavaScript number directly 186.5ms +3.5ms (1%)
Serialization/Write JavaScript string directly 195.25ms +7.5ms (3%)

performance-action

@MaxDesiatov MaxDesiatov added the bug Something isn't working label Oct 26, 2020
@MaxDesiatov MaxDesiatov merged commit 2a90f54 into main Oct 26, 2020
@MaxDesiatov MaxDesiatov deleted the fix-branch-triple branch October 26, 2020 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.