updated versions for release#3388
Merged
updated versions for release#3388
Conversation
Contributor
|
See #3004 for the parser upgrade |
Contributor
Author
|
@cbornet that is a huge PR. I can try merging into this branch |
Contributor
Author
…er-codegen into wing328-java_fix_apiclient
Contributor
|
No problem. |
Contributor
|
On the other hand, I think that upgrading the parser without merging my PR can lead to surprises as allOf will no longer set the parent and this is an issue when you have a discriminator (see Dog/Cat/Animal). So maybe wait my PR to upgrade the parser. |
Contributor
Author
Contributor
Contributor
Author
|
OK I will have to adjust the PR then. |
Contributor
|
UPDATE: I'm drafting the release note, which is 50% done. |
Contributor
|
Maybe just pick 2ce9a11 which sets the interface that has a discriminator as parent. And check that the generated samples don't change (if not included, Cat & Dog will no longer extend Animal). |
If a composed model (allOf) doesn't have any parent and one of its interface has a discriminator field, then set this interface as parent. See #2096 See swagger-api/swagger-parser#246
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.