Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Fix inheritance issues due to duplicated properties in java#3004

Closed
cbornet wants to merge 3 commits intoswagger-api:masterswagger-api/swagger-codegen:masterfrom
cbornet:parent_discrimatorcbornet/swagger-codegen:parent_discrimatorCopy head branch name to clipboard
Closed

Fix inheritance issues due to duplicated properties in java#3004
cbornet wants to merge 3 commits intoswagger-api:masterswagger-api/swagger-codegen:masterfrom
cbornet:parent_discrimatorcbornet/swagger-codegen:parent_discrimatorCopy head branch name to clipboard

Conversation

@cbornet
Copy link
Contributor

@cbornet cbornet commented May 30, 2016

  • If a composed model (allOf) doesn't have any parent and one of its interface has a discriminator field, then set this interface as parent.
  • Upgrade to v1.0.21 of the parser (see Don't configure the parent with allOf swagger-parser#246)
  • Configure supportsInheritance=true for java based gens.

Fix #2096
Fix #3147
Fix #1556
Fix #1348

@wing328 wing328 added this to the v2.2.0 milestone May 31, 2016
@wing328 wing328 modified the milestones: v2.3.0, v2.2.0 Jul 7, 2016
@cbornet cbornet force-pushed the parent_discrimator branch 2 times, most recently from b331b13 to a346358 Compare July 15, 2016 15:26
@cbornet cbornet changed the title set interface with discriminator as parent Fix inheritance issues due to duplicated properties in java Jul 15, 2016
@cbornet
Copy link
Contributor Author

cbornet commented Jul 15, 2016

Now ready for review/merge.

@cbornet cbornet force-pushed the parent_discrimator branch from 2bbf334 to da91d61 Compare July 18, 2016 14:07
@cbornet
Copy link
Contributor Author

cbornet commented Jul 18, 2016

Since the discriminator commits have been done in another PR, I'm closing this one and will do a simpler one for the supportsInheritance in java.

@cbornet cbornet closed this Jul 18, 2016
@wing328
Copy link
Contributor

wing328 commented Jul 18, 2016

Thanks @cbornet (and sorry that you've to do it again with another PR due to the release)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.