Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit ca590cc

Browse filesBrowse files
authored
fix: show simple typos reporting (#7606)
1 parent a30a188 commit ca590cc
Copy full SHA for ca590cc

2 files changed

+15-8Lines changed: 15 additions & 8 deletions

File tree

Expand file treeCollapse file tree
Open diff view settings
Filter options
Expand file treeCollapse file tree
Open diff view settings
Collapse file

‎packages/cspell/src/util/reporters.ts‎

Copy file name to clipboardExpand all lines: packages/cspell/src/util/reporters.ts
+14-7Lines changed: 14 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -40,13 +40,20 @@ function filterFeatureIssues(
4040
return true;
4141
}
4242
// The reporter doesn't support the `unknownWords` feature. Handle the logic here.
43-
let reportIssue = issue.isFlagged;
44-
reportIssue ||= !reportOptions.unknownWords || reportOptions.unknownWords === unknownWordsChoices.ReportAll;
45-
reportIssue ||= reportOptions.unknownWords === unknownWordsChoices.ReportSimple && issue.hasSimpleSuggestions;
46-
reportIssue ||=
47-
reportOptions.unknownWords === unknownWordsChoices.ReportCommonTypos && issue.hasPreferredSuggestions;
48-
49-
return reportIssue || false;
43+
if (
44+
issue.isFlagged ||
45+
!reportOptions.unknownWords ||
46+
reportOptions.unknownWords === unknownWordsChoices.ReportAll
47+
) {
48+
return true;
49+
}
50+
if (issue.hasPreferredSuggestions && reportOptions.unknownWords !== unknownWordsChoices.ReportFlagged) {
51+
return true;
52+
}
53+
if (issue.hasSimpleSuggestions && reportOptions.unknownWords === unknownWordsChoices.ReportSimple) {
54+
return true;
55+
}
56+
return false;
5057
}
5158

5259
function handleIssue(reporter: CSpellReporter, issue: Issue, reportOptions?: ReportIssueOptions | undefined): void {
Collapse file

‎packages/cspell/tools/patch-version.mjs‎

Copy file name to clipboardExpand all lines: packages/cspell/tools/patch-version.mjs
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
import { promises as fs } from 'node:fs';
22

33
const urlPackageJson = new URL('../package.json', import.meta.url);
4-
const urlVersionFile = new URL('../src/app/pkgInfo.ts', import.meta.url);
4+
const urlVersionFile = new URL('../src/pkgInfo.ts', import.meta.url);
55

66
async function readPackageJson() {
77
const pkgJson = await fs.readFile(urlPackageJson, 'utf8');

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.