Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Add NUCLEO-C092RC variant #2735

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 26, 2025
Merged

Add NUCLEO-C092RC variant #2735

merged 4 commits into from
May 26, 2025

Conversation

showengineer
Copy link
Contributor

@showengineer showengineer commented May 22, 2025

Summary

This PR fixes/implements the following bugs/features

  • Adding NUCLEO-C092RC board as a variant
  • Maps USART3_IRQn and USART4_IRQn to USART3_4_IRQn for STM32C0 processors

Validation

  • Ensure CI build is passed.
  • Checked with CheckVariant sketch

Code formatting

  • Ensure AStyle check is passed thanks CI

Notes
I mostly copied the variant files from the NUCLEO-C071RB variant, since both chips share the same pinout and most peripherals. I have not checked if FDCAN works, all else seems to work perfectly fine.

Copy link
Member

@fpistm fpistm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @showengineer

Thanks for the PR.
I've made a first review, could you add also the generic (clock config, boards.txt, and reference in the README.md).
And fix the astyle issues.

README.md Outdated Show resolved Hide resolved
libraries/SrcWrapper/inc/uart.h Outdated Show resolved Hide resolved
libraries/SrcWrapper/inc/uart.h Outdated Show resolved Hide resolved
@fpistm fpistm added the new variant Add support of new bard label May 22, 2025
@fpistm fpistm added this to the 2.11.0 milestone May 22, 2025
@fpistm fpistm mentioned this pull request May 22, 2025
85 tasks
@showengineer
Copy link
Contributor Author

showengineer commented May 22, 2025

Hm, you would expect that if you'd run astyle to fix formatting, that the same astyle would also pass all the formatting checks...

@fpistm
Copy link
Member

fpistm commented May 23, 2025

Hm, you would expect that if you'd run astyle to fix formatting, that the same astyle would also pass all the formatting checks...

Yes but they are rules and configuration to use.
See https://github.com/stm32duino/Arduino_Core_STM32/wiki/Astyle

showengineer and others added 4 commits May 26, 2025 11:04
Co-authored-by: Frederic Pillon <frederic.pillon@st.com>
Signed-off-by: Hugo <10338882+showengineer@users.noreply.github.com>
Co-authored-by: Frederic Pillon <frederic.pillon@st.com>
Signed-off-by: Hugo <10338882+showengineer@users.noreply.github.com>
Signed-off-by: Hugo <10338882+showengineer@users.noreply.github.com>
Signed-off-by: Frederic Pillon <frederic.pillon@st.com>
@fpistm
Copy link
Member

fpistm commented May 26, 2025

I've clean up your PR:

  • remove custom PeripheralPins.c
  • apply astyle using the scripts mentioned above
  • add generic

@github-project-automation github-project-automation bot moved this from In progress to Reviewer approved in STM32 core based on ST HAL May 26, 2025
@showengineer
Copy link
Contributor Author

Ah thank you. Sorry, I am currently on vacation for a week without a laptop so I wasn't able to fix the rest yet.

@fpistm fpistm merged commit cb5742d into stm32duino:main May 26, 2025
24 of 25 checks passed
@github-project-automation github-project-automation bot moved this from Reviewer approved to Done in STM32 core based on ST HAL May 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new variant Add support of new bard
Projects
Development

Successfully merging this pull request may close these issues.

2 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.