stacktracejs · oliversalzburg · Oct 18, 2015 · Oct 15, 2015 · houndci-bot · Oct 16, 2015
diff --git a/.jshintignore b/.jshintignore
@@ -0,0 +1 @@
+dist/*
diff --git a/.jshintrc b/.jshintrc
@@ -44,6 +44,7 @@
        "JASMINE": true,
        "JASMINE_ADAPTER": true,
        "matchers": true,
-        "priv": true
+        "priv": true,
+        "JSON": true
    }
 }
diff --git a/dist/stacktrace-with-polyfills.min.js b/dist/stacktrace-with-polyfills.min.js
diff --git a/dist/stacktrace-with-polyfills.min.js.map b/dist/stacktrace-with-polyfills.min.js.map
diff --git a/dist/stacktrace.js b/dist/stacktrace.js
@@ -178,7 +178,7 @@
                };
                req.open('post', url);
                req.setRequestHeader('Content-Type', 'application/json');
-                req.send({stack: stackframes});
+                req.send(JSON.stringify({stack: stackframes}));
            });
        }
    };

diff --git a/dist/stacktrace.min.js b/dist/stacktrace.min.js
diff --git a/dist/stacktrace.min.js.map b/dist/stacktrace.min.js.map
diff --git a/gulpfile.js b/gulpfile.js
@@ -10,6 +10,7 @@ var uglify = require('gulp-uglify');

 var polyfills = [
    './node_modules/es6-promise/dist/es6-promise.js',
+    './node_modules/json3/lib/json3.js',
    './polyfills.js'
 ];
 var dependencies = [

diff --git a/package.json b/package.json
@@ -37,6 +37,7 @@
        "gulp-uglify": "^1.4.1",
        "jasmine-node": "~1.14",
        "jasmine-sinon": "^0.4.0",
+        "json3": "^3.3.2",
        "karma": "^0.13.9",
        "karma-chrome-launcher": "^0.2.0",
        "karma-coverage": "^0.5.2",

diff --git a/spec/stacktrace-spec.js b/spec/stacktrace-spec.js
@@ -230,7 +230,8 @@ describe('StackTrace', function () {
            });
            waits(100);
            runs(function () {
-                expect(server.requests[0].requestBody).toEqual({stack: stackframes});
+                var expectedResponse = JSON.stringify({stack: stackframes});
+                expect(server.requests[0].requestBody).toEqual(expectedResponse);
                expect(server.requests[0].url).toEqual(url);
                expect(callback).toHaveBeenCalledWith('OK');
                expect(errback).not.toHaveBeenCalled();

diff --git a/stacktrace.js b/stacktrace.js
@@ -178,7 +178,7 @@
                };
                req.open('post', url);
                req.setRequestHeader('Content-Type', 'application/json');
-                req.send({stack: stackframes});
+                req.send(JSON.stringify({stack: stackframes}));
            });
        }
    };
-Original file line number
+Diff line change
@@ -230,7 +230,8 @@ describe('StackTrace', function () {
                 });
                 waits(100);
                 runs(function () {
-                    expect(server.requests[0].requestBody).toEqual({stack: stackframes});
+                    var expectedResponse = JSON.stringify({stack: stackframes});
+                    expect(server.requests[0].requestBody).toEqual(expectedResponse);
         Comment thread


        

        
      

        
          


  
    
        
        
  
    
      
          
      

      
            houndci-bot
  

      

      

      


        Oct 16, 2015



      
    

  

  
    
      
          
    
  


        
            
  
      
              Copy link

  
              
  
      
                Copy Markdown

  
        
      
    

    
        



        

    
  


        
      
  
  
  
    

    There was a problem hiding this comment.


  

 
  
    

    Choose a reason for hiding this comment

    
      The reason will be displayed to describe this comment to others. Learn more.
    

    
      
      


  


  
    
      Line is too long.
    
  
  



    

        
      
  
  
    
  
  
  
    
    Sorry, something went wrong.
  

  
    
  
    
      

              Uh oh!

              
There was an error while loading. Please reload this page.


  
  


          
              
  
    
    
      
        
            
    All reactions
  


          
          
        
      
    


      



    
        
  
    
      
          
      

      
            oliversalzburg
  

      

      

      


        Oct 16, 2015



      
    

  

  
    
      
          
    
  


        
            
  
      
              Copy link

  
              
  
      
                Copy Markdown

  
        
      
    

    
        

  
    Contributor


        

  Author


    
  


        
      
  
  
  
    

    There was a problem hiding this comment.


  

 
  
    

    Choose a reason for hiding this comment

    
      The reason will be displayed to describe this comment to others. Learn more.
    

    
      
      


  


  
    
      How can that still be too long? O_o
    
  
  



    

        
      
  
  
    
  
  
  
    
    Sorry, something went wrong.
  

  
    
  
    
      

              Uh oh!

              
There was an error while loading. Please reload this page.


  
  


          
              
  
    
    
      
        
            
    All reactions
  


          
          
        
      
    


      



    
        
  
    
      
          
      

      
            eriwen
  

      

      

      


        Oct 17, 2015



      
    

  

  
    
      
          
    
  


        
            
  
      
              Copy link

  
              
  
      
                Copy Markdown

  
        
      
    

    
        

  
  Member


        

    
  


        
      
  
  
  
    

    There was a problem hiding this comment.


  

 
  
    

    Choose a reason for hiding this comment

    
      The reason will be displayed to describe this comment to others. Learn more.
    

    
      
      


  


  
    
      Hm.. I'm guessing the default line length limit is 80.
Sorry about the annoying Hound stuff; don't worry about this kinda thing. I may just disable it since JSHint is part of the build anyway.
    
  
  



    

        
      
  
  
    
  
  
  
    
    Sorry, something went wrong.
  

  
    
  
    
      

              Uh oh!

              
There was an error while loading. Please reload this page.


  
  


          
              
  
    
    
      
        
            
    All reactions
                     expect(server.requests[0].url).toEqual(url);
                     expect(callback).toHaveBeenCalledWith('OK');
                     expect(errback).not.toHaveBeenCalled();
-          Expand Down