Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions 1 .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -10,3 +10,4 @@ coverage

.idea
.coveralls.yml
dist
7 changes: 4 additions & 3 deletions 7 .travis.yml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
language: node_js
sudo: required
dist: trusty
node_js: stable
dist: xenial
node_js: 8
addons:
sauce_connect: true
firefox: latest
Expand All @@ -10,10 +10,11 @@ addons:
- google-chrome
packages:
- google-chrome-stable
services:
- xvfb
before_install:
- export CHROME_BIN=chromium-browser
- export DISPLAY=:99.0
- sh -e /etc/init.d/xvfb start
before_script:
- npm install
script:
Expand Down
6 changes: 3 additions & 3 deletions 6 spec/stackframe-spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -158,8 +158,8 @@ describe('StackFrame', function() {
});

describe('#toString', function() {
it('represents empty StackFrame as "{anonymous}()"', function() {
expect(new StackFrame().toString()).toEqual('{anonymous}()');
it('represents empty StackFrame as "::"', function() {
expect(new StackFrame().toString()).toEqual('::');
});
it('represents complete StackFrame same as old stacktrace.js', function() {
var unit = new StackFrame({
Expand All @@ -172,7 +172,7 @@ describe('StackFrame', function() {
isNative: false,
source: 'SOURCE'
});
expect(unit.toString()).toEqual('fun(arg1,arg2)@http://site.com/path.js:1:4567');
expect(unit.toString()).toEqual('fun (http://site.com/path.js:1:4567)');
});
});
});
20 changes: 14 additions & 6 deletions 20 stackframe.js
Original file line number Diff line number Diff line change
Expand Up @@ -68,12 +68,20 @@
},

toString: function() {
var functionName = this.getFunctionName() || '{anonymous}';
var args = '(' + (this.getArgs() || []).join(',') + ')';
var fileName = this.getFileName() ? ('@' + this.getFileName()) : '';
var lineNumber = _isNumber(this.getLineNumber()) ? (':' + this.getLineNumber()) : '';
var columnNumber = _isNumber(this.getColumnNumber()) ? (':' + this.getColumnNumber()) : '';
return functionName + args + fileName + lineNumber + columnNumber;
var fileName = this.getFileName() || '';
var lineNumber = this.getLineNumber() || '';
var columnNumber = this.getColumnNumber() || '';
var functionName = this.getFunctionName() || '';
if (this.getIsEval()) {
if (fileName) {
return '[eval] (' + fileName + ':' + lineNumber + ':' + columnNumber + ')';
}
return '[eval]:' + lineNumber + ':' + columnNumber;
}
if (functionName) {
return functionName + ' (' + fileName + ':' + lineNumber + ':' + columnNumber + ')';
}
return fileName + ':' + lineNumber + ':' + columnNumber;
}
};

Expand Down
Morty Proxy This is a proxified and sanitized view of the page, visit original site.