Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Fully parse function names with @ in Error.stack#27

Merged
eriwen merged 1 commit into
stacktracejs:masterstacktracejs/error-stack-parser:masterfrom
leonidborisenko:fully-parse-fn-name-with-at-signleonidborisenko/error-stack-parser:fully-parse-fn-name-with-at-signCopy head branch name to clipboard
Jan 3, 2016
Merged

Fully parse function names with @ in Error.stack#27
eriwen merged 1 commit into
stacktracejs:masterstacktracejs/error-stack-parser:masterfrom
leonidborisenko:fully-parse-fn-name-with-at-signleonidborisenko/error-stack-parser:fully-parse-fn-name-with-at-signCopy head branch name to clipboard

Conversation

@leonidborisenko

@leonidborisenko leonidborisenko commented Jan 3, 2016

Copy link
Copy Markdown
Contributor

Function name in Error.stack can contain @ when function is defined as an object property:

const obj = { '@fn'() { throw new Error(); } };
obj['@fn']();
/*
Exception: Error
obj["@fn"]@Scratchpad/1:10:31
@Scratchpad/1:11:1
*/

@leonidborisenko
Fully parse function names with @ in Error.stack
b783149 
Function name in Error.stack can contain @ when function is defined as an
object property:

    const obj = { '@fn'() { throw new Error(); } };
    obj['@fn']();
    /*
    Exception: Error
    obj["@fn"]@Scratchpad/1:10:31
    @Scratchpad/1:11:1
    */
@eriwen

eriwen commented Jan 3, 2016

Copy link
Copy Markdown
Member

This looks great! Thank you for contributing!

eriwen added a commit that referenced this pull request Jan 3, 2016
@eriwen
Merge pull request #27 from leonidborisenko/fully-parse-fn-name-with-…
e3eae6a 
…at-sign

Fully parse function names with @ in Error.stack
@eriwen eriwen merged commit e3eae6a into stacktracejs:master Jan 3, 2016
eriwen added a commit that referenced this pull request Apr 16, 2016
@eriwen
Merge pull request #27 from leonidborisenko/fully-parse-fn-name-with-…
db4e196 
…at-sign

Fully parse function names with @ in Error.stack
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@leonidborisenko @eriwen
Morty Proxy This is a proxified and sanitized view of the page, visit original site.