ROX-30918, ROX-31049: Update labels, fix docker mediaType#17262
ROX-30918, ROX-31049: Update labels, fix docker mediaType#17262msugakov merged 4 commits intomasterstackrox/stackrox:masterfrom misha/ROX-30918-update-konflux-labelsstackrox/stackrox:misha/ROX-30918-update-konflux-labelsCopy head branch name to clipboard
Conversation
|
Skipping CI for Draft Pull Request. |
1c8fda8 to
24d7dd2
Compare
|
Images are ready for the commit at 6f1821c. To use with deploy scripts, first |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #17262 +/- ##
=======================================
Coverage 48.86% 48.86%
=======================================
Files 2720 2720
Lines 203374 203365 -9
=======================================
- Hits 99377 99374 -3
+ Misses 96175 96169 -6
Partials 7822 7822
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
via `BUILD_TIMESTAMP` param.
To future-proof ROX-31049. It's likely the corresponding buildah update isn't yet there but supplying extra param won't hurt. Either I'll bump buildah as part of this PR or we'll rebase MintMaker changes.
24d7dd2 to
6f1821c
Compare
|
The adapted version of check.sh (similar to the one in scanner stackrox/collector#2568 (comment) but with a special treatment for operator-bundle as it's single-arch and does not have image index): #!/usr/bin/env bash
set -euo pipefail
tag="4.10.0-33-g6f1821c115-fast"
parent="quay.io/rhacs-eng"
repos=(release-central-db release-main release-operator release-roxctl release-scanner-v4 release-scanner-v4-db)
arch_suffixes=(amd64 s390x ppc64le arm64)
echo " >>> Checking mediaType on indexes"
for repo in "${repos[@]}"; do
index="${parent}/${repo}:${tag}"
echo " >>> on ${index}"
skopeo inspect --raw "docker://${index}" | jq | grep mediaType
done
echo " >>> Checking mediaType on images"
for repo in "${repos[@]}"; do
index="${parent}/${repo}:${tag}"
for arch in "${arch_suffixes[@]}"; do
image="${index}-${arch}"
echo " >>> on ${image}"
skopeo inspect --raw "docker://${image}" | jq | grep mediaType
done
done
image="${parent}/release-operator-bundle:v${tag}"
echo " >>> on ${image}"
skopeo inspect --raw "docker://${image}" | jq | grep mediaType
echo " >>> Checking labels on images"
for repo in "${repos[@]}"; do
index="${parent}/${repo}:${tag}"
for arch in "${arch_suffixes[@]}"; do
image="${index}-${arch}"
echo " >>> on ${image}"
skopeo inspect --no-tags "docker://${image}" | grep -E '"(cpe|name|org.opencontainers.image.created)"'
done
done
image="${parent}/release-operator-bundle:v${tag}"
echo " >>> on ${image}"
skopeo inspect --no-tags "docker://${image}" | grep -E '"(cpe|name|org.opencontainers.image.created)"'Interestingly, the printed media types are |
Description
Similar to stackrox/scanner#2300 but in the StackRox repo.
User-facing documentation
Testing and quality
Automated testing
No change.
How I validated my change
Looked at mediaType-s and labels on the resulting images using the script (below).