Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

ROX-30918, ROX-31049: Update labels, fix docker mediaType#17262

Merged
msugakov merged 4 commits intomasterstackrox/stackrox:masterfrom
misha/ROX-30918-update-konflux-labelsstackrox/stackrox:misha/ROX-30918-update-konflux-labelsCopy head branch name to clipboard
Oct 15, 2025
Merged

ROX-30918, ROX-31049: Update labels, fix docker mediaType#17262
msugakov merged 4 commits intomasterstackrox/stackrox:masterfrom
misha/ROX-30918-update-konflux-labelsstackrox/stackrox:misha/ROX-30918-update-konflux-labelsCopy head branch name to clipboard

Conversation

@msugakov
Copy link
Contributor

@msugakov msugakov commented Oct 13, 2025

Description

Similar to stackrox/scanner#2300 but in the StackRox repo.

User-facing documentation

Testing and quality

  • the change is production ready: the change is GA, or otherwise the functionality is gated by a feature flag
  • CI results are inspected

Automated testing

No change.

How I validated my change

Looked at mediaType-s and labels on the resulting images using the script (below).

@msugakov msugakov added do-not-merge/work-in-progress konflux-build Run Konflux in PR. Push commit to trigger it. labels Oct 13, 2025
@openshift-ci
Copy link

openshift-ci bot commented Oct 13, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@rhacs-bot
Copy link
Contributor

rhacs-bot commented Oct 13, 2025

Images are ready for the commit at 6f1821c.

To use with deploy scripts, first export MAIN_IMAGE_TAG=4.10.x-33-g6f1821c115.

@codecov
Copy link

codecov bot commented Oct 13, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 48.86%. Comparing base (4264cf3) to head (6f1821c).
⚠️ Report is 6 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #17262   +/-   ##
=======================================
  Coverage   48.86%   48.86%           
=======================================
  Files        2720     2720           
  Lines      203374   203365    -9     
=======================================
- Hits        99377    99374    -3     
+ Misses      96175    96169    -6     
  Partials     7822     7822           
Flag Coverage Δ
go-unit-tests 48.86% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

To future-proof ROX-31049.
It's likely the corresponding buildah update isn't yet there but
supplying extra param won't hurt.
Either I'll bump buildah as part of this PR or we'll rebase
MintMaker changes.
@msugakov msugakov force-pushed the misha/ROX-30918-update-konflux-labels branch from 24d7dd2 to 6f1821c Compare October 15, 2025 10:58
@msugakov msugakov changed the title ROX-30918: Update labels ROX-30918, ROX-31049: Update labels, prepare mediaType Oct 15, 2025
@msugakov
Copy link
Contributor Author

msugakov commented Oct 15, 2025

The adapted version of check.sh (similar to the one in scanner stackrox/collector#2568 (comment) but with a special treatment for operator-bundle as it's single-arch and does not have image index):

#!/usr/bin/env bash

set -euo pipefail

tag="4.10.0-33-g6f1821c115-fast"
parent="quay.io/rhacs-eng"
repos=(release-central-db release-main release-operator release-roxctl release-scanner-v4 release-scanner-v4-db)
arch_suffixes=(amd64 s390x ppc64le arm64)

echo " >>> Checking mediaType on indexes"

for repo in "${repos[@]}"; do
  index="${parent}/${repo}:${tag}"
  echo "  >>> on ${index}"
  skopeo inspect --raw "docker://${index}" | jq | grep mediaType
done

echo " >>> Checking mediaType on images"

for repo in "${repos[@]}"; do
  index="${parent}/${repo}:${tag}"

  for arch in "${arch_suffixes[@]}"; do
    image="${index}-${arch}"
    echo "  >>> on ${image}"
    skopeo inspect --raw "docker://${image}" | jq | grep mediaType
  done
done

image="${parent}/release-operator-bundle:v${tag}"
echo "  >>> on ${image}"
skopeo inspect --raw "docker://${image}" | jq | grep mediaType

echo " >>> Checking labels on images"

for repo in "${repos[@]}"; do
  index="${parent}/${repo}:${tag}"

  for arch in "${arch_suffixes[@]}"; do
    image="${index}-${arch}"
    echo "  >>> on ${image}"
    skopeo inspect --no-tags "docker://${image}" | grep -E '"(cpe|name|org.opencontainers.image.created)"'
  done
done

image="${parent}/release-operator-bundle:v${tag}"
echo "  >>> on ${image}"
skopeo inspect --no-tags "docker://${image}" | grep -E '"(cpe|name|org.opencontainers.image.created)"'

Interestingly, the printed media types are docker and not oci. This means our old version of the task already supported the parameter even without the updates.

@msugakov msugakov merged commit f187054 into master Oct 15, 2025
121 of 129 checks passed
@msugakov msugakov deleted the misha/ROX-30918-update-konflux-labels branch October 15, 2025 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments

Close sidebar
Morty Proxy This is a proxified and sanitized view of the page, visit original site.