Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Comments

Close side panel

ROX-30918, ROX-31049: Update labels, fix docker mediaType / 4.9#17312

Merged
msugakov merged 2 commits intorelease-4.9stackrox/stackrox:release-4.9from
misha/ROX-30918-backports-4.9stackrox/stackrox:misha/ROX-30918-backports-4.9Copy head branch name to clipboard
Oct 16, 2025
Merged

ROX-30918, ROX-31049: Update labels, fix docker mediaType / 4.9#17312
msugakov merged 2 commits intorelease-4.9stackrox/stackrox:release-4.9from
misha/ROX-30918-backports-4.9stackrox/stackrox:misha/ROX-30918-backports-4.9Copy head branch name to clipboard

Conversation

@msugakov
Copy link
Contributor

@msugakov msugakov commented Oct 15, 2025

Description

Backport of #17262 to the release branch.

User-facing documentation

Testing and quality

  • the change is production ready: the change is GA, or otherwise the functionality is gated by a feature flag
  • CI results are inspected

Automated testing

No.

How I validated my change

By looking at the output of my check script #17262 (comment) against 4.9.0-rc.0-4-g96aaf8e43f tag.

@openshift-ci
Copy link

openshift-ci bot commented Oct 15, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request #17312 has too many files changed.

The GitHub API will only let us fetch up to 300 changed files, and this pull request has 766.

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request #17312 has too many files changed.

The GitHub API will only let us fetch up to 300 changed files, and this pull request has 766.

@msugakov msugakov force-pushed the misha/ROX-30918-backports-4.9 branch from b6aecf7 to 96aaf8e Compare October 15, 2025 16:59
@msugakov msugakov changed the title ROX-30918: Update cpe label to 4.9 ROX-30918, ROX-31049: Update labels, fix docker mediaType / 4.9 Oct 15, 2025
@msugakov msugakov marked this pull request as ready for review October 15, 2025 17:03
@msugakov msugakov requested a review from a team as a code owner October 15, 2025 17:03
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@rhacs-bot
Copy link
Contributor

rhacs-bot commented Oct 15, 2025

Images are ready for the commit at 96aaf8e.

To use with deploy scripts, first export MAIN_IMAGE_TAG=4.10.x-36-gb6aecf77f4.

@msugakov
Copy link
Contributor Author

/retest

@codecov
Copy link

codecov bot commented Oct 15, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 48.84%. Comparing base (4ab1e04) to head (96aaf8e).

Additional details and impacted files
@@             Coverage Diff              @@
##           release-4.9   #17312   +/-   ##
============================================
  Coverage        48.84%   48.84%           
============================================
  Files             2717     2717           
  Lines           203231   203231           
============================================
+ Hits             99264    99271    +7     
+ Misses           96151    96144    -7     
  Partials          7816     7816           
Flag Coverage Δ
go-unit-tests 48.84% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@openshift-ci
Copy link

openshift-ci bot commented Oct 15, 2025

@msugakov: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/ocp-next-candidate-qa-e2e-tests 96aaf8e link false /test ocp-next-candidate-qa-e2e-tests

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@msugakov
Copy link
Contributor Author

/retest operator-bundle-on-push

@stackrox stackrox deleted a comment from openshift-ci bot Oct 16, 2025
@msugakov msugakov merged commit 50644b0 into release-4.9 Oct 16, 2025
145 of 149 checks passed
@msugakov msugakov deleted the misha/ROX-30918-backports-4.9 branch October 16, 2025 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.