Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

test: add methodselect unit testing#613

Merged
general-kroll-4-life merged 1 commit into
stackql:mainstackql/stackql:mainfrom
BenjaminGoehry:test/methodselectBenjaminGoehry/stackql:test/methodselectCopy head branch name to clipboard
Feb 16, 2026
Merged

test: add methodselect unit testing#613
general-kroll-4-life merged 1 commit into
stackql:mainstackql/stackql:mainfrom
BenjaminGoehry:test/methodselectBenjaminGoehry/stackql:test/methodselectCopy head branch name to clipboard

Conversation

@BenjaminGoehry
Copy link
Copy Markdown
Contributor

@BenjaminGoehry BenjaminGoehry commented Feb 6, 2026

Closes #242

Summary:

Add comprehensive unit tests for the methodselect package, covering all core functions:

  • GetMethodForAction: Tests supported actions (SELECT, mixed case), unsupported actions, and error handling.
  • GetMethod: Tests retrieval of existing and non-existent methods.
  • getMethodByNameAndParameters: Tests method lookup with and without parameters.
  • NewMethodSelector: Tests initialization for supported and unsupported providers.
    All tests use the aws provider and bucket_acls resource for consistency.
image

@BenjaminGoehry BenjaminGoehry marked this pull request as ready for review February 6, 2026 15:35
@general-kroll-4-life
Copy link
Copy Markdown
Contributor

@BenjaminGoehry thanks for the contribution. Can you please attend tot he linting error, at the time of writing this is Error: internal/stackql/methodselect/methodselect_test.go:1:9: package should be methodselect_testinstead ofmethodselect (testpackage)

@BenjaminGoehry
Copy link
Copy Markdown
Contributor Author

@general-kroll-4-life Thanks, I updated it 🚀

@general-kroll-4-life general-kroll-4-life merged commit bf3c2da into stackql:main Feb 16, 2026
16 of 19 checks passed
@general-kroll-4-life
Copy link
Copy Markdown
Contributor

@BenjaminGoehry thank you kindly for your contribution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unit testing for package methodselect

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.