Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

test: add unit and integration tests for annotatedast#612

Merged
general-kroll-4-life merged 9 commits into
stackql:mainstackql/stackql:mainfrom
Sneha41sb:test/annotatedast-coverage-85Sneha41sb/stackql:test/annotatedast-coverage-85Copy head branch name to clipboard
Mar 12, 2026
Merged

test: add unit and integration tests for annotatedast#612
general-kroll-4-life merged 9 commits into
stackql:mainstackql/stackql:mainfrom
Sneha41sb:test/annotatedast-coverage-85Sneha41sb/stackql:test/annotatedast-coverage-85Copy head branch name to clipboard

Conversation

@Sneha41sb
Copy link
Copy Markdown
Contributor

Summary

This PR improves test coverage for the annotatedast package by adding unit and integration tests.

Details

  • Added new tests without modifying production code
  • Improved coverage for reachable logic paths
  • Avoided mocking non-exported internal types

Coverage Notes

Some functions depend on planner-injected AST state or internal types and cannot be safely unit-tested. Coverage has been improved as far as possible without violating package boundaries.

@Sneha41sb
Copy link
Copy Markdown
Contributor Author

Hi maintainers
This PR adds unit and integration tests to improve coverage for annotatedast.
Some branches depend on planner-injected AST state and cannot be unit-tested safely, so coverage was improved as far as possible without modifying production code.

Happy to adjust if you’d like changes — thanks!

@general-kroll-4-life
Copy link
Copy Markdown
Contributor

@Sneha41sb thanks for the contribution. Please remove all files other that the *_test.go files

@general-kroll-4-life
Copy link
Copy Markdown
Contributor

@Sneha41sb can you please fix the issues picked up by the linter

@general-kroll-4-life general-kroll-4-life merged commit 3374f33 into stackql:main Mar 12, 2026
18 of 19 checks passed
@general-kroll-4-life
Copy link
Copy Markdown
Contributor

@Sneha41sb thanks for this contribution. I removed a few artifacts and allow listed some things the linter flagged. Please accept our thanks and come back any time

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.