This repository was archived by the owner on Jun 5, 2025. It is now read-only.
Merged
Strip attachments from copilot messages when handling the CLI commands#1202
Conversation
JAORMX
previously approved these changes
Mar 4, 2025
| Returns: | ||
| Optional[re.Match[str]]: A regex match object if command is found, None otherwise | ||
| """ | ||
| cleaned_text = re.sub(r'<attachment>.*</attachment>', '', last_user_message_str, flags=re.DOTALL) |
Contributor
There was a problem hiding this comment.
optimization: pre-declare and pre-compile each regular expression in the constructor or even globally so this function would only need to evaluate the regex as opposed to compile+evaluate.
Contributor
Author
There was a problem hiding this comment.
let's do it separately for all the regexes here. We should also move the client helpers to the client interface.
Copilot sends files in the context in the following format: ``` <attachment> file <attachment> user query ``` Fixes: #1061
JAORMX
approved these changes
Mar 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Copilot sends files in the context in the following format:
Fixes: #1061