This repository was archived by the owner on Jun 5, 2025. It is now read-only.
Fix muxing integration tests#1189
Merged
Merged
Conversation
There seemed to be a race condition between two different commits on the same day, one of which renamed a method and the failure to call the method was shadowed by a try-except. The result was that we couldn't run the muxing integration tests.
blkt
approved these changes
Mar 3, 2025
JAORMX
approved these changes
Mar 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There seemed to be a race condition between two different commits on the
same day, one of which renamed a method and the failure to call the
method was shadowed by a try-except. The result was that we couldn't run
the muxing integration tests.