This repository was archived by the owner on Jun 5, 2025. It is now read-only.
Closed
feat: add pagination to alerts and messages endpoints#1186
Conversation
Modify the API to add pagination to those endpoints, to be able to render faster in the browser Closes: #1020
Contributor
|
Copying this from Slack, so it doesn't get buried in discussion. In early testing, we all saw crashed in the frontend — our Table implementation expects that chat_id on each object in the list of messages is unique — I am seeing some duplication in the response, e.g. |
* feat: filter messages by ID * lint fix * fix: use `.bindparams` for `filter_by_ids`
This was referenced Mar 4, 2025
Contributor
Author
|
closed in favor of @alex-mcgovern PR |
This was referenced Mar 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modify the API to add pagination to those endpoints, to be able to render faster in the browser
Closes: #1020