Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings
This repository was archived by the owner on Jun 5, 2025. It is now read-only.

Update the muxing rules to v3#1112

Merged
aponcedeleonch merged 2 commits into
mainstacklok/codegate:mainfrom
mux-requests-per-filetypestacklok/codegate:mux-requests-per-filetypeCopy head branch name to clipboard
Feb 21, 2025
Merged

Update the muxing rules to v3#1112
aponcedeleonch merged 2 commits into
mainstacklok/codegate:mainfrom
mux-requests-per-filetypestacklok/codegate:mux-requests-per-filetypeCopy head branch name to clipboard

Conversation

@aponcedeleonch

Copy link
Copy Markdown
Member

Closes: #1060

Right now the muxing rules are designed to catch globally FIM or Chat requests. This PR extends its functionality to be able to match per file and request, i.e. this PR enables

  • Chat request of main.py -> model 1
  • FIM request of main.py -> model 2
  • Any type of v1.py -> model 3

@aponcedeleonch

Copy link
Copy Markdown
Member Author

Marking as draft because this would break the FE. We need to coordinate to merge

@aponcedeleonch aponcedeleonch marked this pull request as draft February 19, 2025 15:23
@lukehinds

Copy link
Copy Markdown

API Version 3?

@peppescg

Copy link
Copy Markdown
Contributor

on it stacklok/codegate-ui#319 👨‍💻

Comment thread src/codegate/muxing/rulematcher.py Outdated
@JAORMX

JAORMX commented Feb 20, 2025

Copy link
Copy Markdown
Contributor

uhm... I'd be careful with having a v3 that's not backwards compatible without more usecases. This already starts looking too optimized for fim/chat in a way that it might not cater for other rule types.

@aponcedeleonch

aponcedeleonch commented Feb 20, 2025

Copy link
Copy Markdown
Member Author

This already starts looking too optimized for fim/chat in a way that it might not cater for other rule types.

As I see it, it will be optimized for the request type. Right now we can only distinguish between 2 request types, fim or chat. Hence the types we have. In the future we would be able to match more request types, e.g. request type: Persona based.

But I was afraid of the same thing, of the types being very restrictive. In the end I convince myself that it wasn't as restrictive as I initially thought. But of course all discussions welcomed and any feedback is appreciated 😃

@JAORMX

JAORMX commented Feb 20, 2025

Copy link
Copy Markdown
Contributor

Let's see this in action and I'll keep reviewing in the meantime.

@aponcedeleonch aponcedeleonch marked this pull request as ready for review February 20, 2025 15:45
@aponcedeleonch aponcedeleonch force-pushed the mux-requests-per-filetype branch from 0edea97 to 0890c1a Compare February 20, 2025 15:50
@aponcedeleonch aponcedeleonch force-pushed the mux-requests-per-filetype branch from 9ea1504 to d5957e0 Compare February 21, 2025 09:51
Closes: #1060

Right now the muxing rules are designed to catch globally
FIM or Chat requests. This PR extends its functionality
to be able to match per file and request, i.e. this PR enables
- Chat request of main.py -> model 1
- FIM request of main.py -> model 2
- Any type of v1.py -> model 3
@aponcedeleonch aponcedeleonch force-pushed the mux-requests-per-filetype branch from d5957e0 to 34f4f02 Compare February 21, 2025 09:52
@aponcedeleonch aponcedeleonch merged commit d8b7cbf into main Feb 21, 2025
@aponcedeleonch aponcedeleonch deleted the mux-requests-per-filetype branch February 21, 2025 11:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Task]: Adapt existing rules to work with Chat and FIM

4 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.