This repository was archived by the owner on Jun 5, 2025. It is now read-only.
Fix FIM for OpenRouter#1097
Merged
Merged
Conversation
jhrozek
previously approved these changes
Feb 19, 2025
jhrozek
left a comment
Contributor
There was a problem hiding this comment.
oh, litellm. The gift that keeps on giving.
FIM was not working with OpenRouter in Continue. The reason
was that we get FIM requests in `/completions`. LiteLLM when
using `acompletion` is forcing `/chat/completions` and the return
format `{..., "choices":[{"delta":{"content":"some text"}}]}`.
However, Continue was expecting the format:
`{..., "choices":[{"text":"some text"}]}` becuase of the endpoint
it called.
With this PR we force the return format to be the latter using
`atext_completion` from LiteLLM
270aeec to
e353310
Compare
jhrozek
approved these changes
Feb 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FIM was not working with OpenRouter in Continue. The reason was that we get FIM requests in
/completions. LiteLLM when usingacompletionis forcing/chat/completionsand the return format{..., "choices":[{"delta":{"content":"some text"}}]}. However, Continue was expecting the format:{..., "choices":[{"text":"some text"}]}becuase of the endpoint it called.With this PR we force the return format to be the latter using
atext_completionfrom LiteLLM