This repository was archived by the owner on Jun 5, 2025. It is now read-only.
Generate valid chunked response when returning short circuit answer#1001
Merged
dmjb merged 7 commits intoFeb 14, 2025
stacklok:mainstacklok/codegate:mainfrom
dmjb:fix-chunk-encoding-issuedmjb/codegate:fix-chunk-encoding-issueCopy head branch name to clipboard
Merged
Generate valid chunked response when returning short circuit answer#1001dmjb merged 7 commits intostacklok:mainstacklok/codegate:mainfrom dmjb:fix-chunk-encoding-issuedmjb/codegate:fix-chunk-encoding-issueCopy head branch name to clipboard
dmjb merged 7 commits into
stacklok:mainstacklok/codegate:mainfrom
dmjb:fix-chunk-encoding-issuedmjb/codegate:fix-chunk-encoding-issueCopy head branch name to clipboard
Conversation
Prior to this change, this code would return a malformed HTTP response with a chunk size, then HTTP header, then body, then the final chunk size, final chunk then zero. This changes the code to return the header before returning the code. Furthermore, it does not count the size of the header in the first chunk size.
jhrozek
reviewed
Feb 10, 2025
jhrozek
left a comment
Contributor
There was a problem hiding this comment.
I think this patch makes sense and all my testing in vscode works fine.
jhrozek
approved these changes
Feb 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prior to this change, this code would return a malformed HTTP response with a chunk size, then HTTP header, then body, then the final chunk size, final chunk then zero.
This changes the code to return the header before returning the code. Furthermore, it does not count the size of the header in the first chunk size.
This has been validated as a fix in the scenario where I encountered it, plus in contexts where this flow worked previously.