Fix typos in tools/strip-lib.py#17
Merged
kristjanvalur merged 1 commit intoMar 28, 2026
masterstackless-dev/stackman:masterfrom
copilot/fix-typos-in-strip-lib-pystackless-dev/stackman:copilot/fix-typos-in-strip-lib-pyCopy head branch name to clipboard
Merged
Fix typos in tools/strip-lib.py#17kristjanvalur merged 1 commit intomasterstackless-dev/stackman:masterfrom copilot/fix-typos-in-strip-lib-pystackless-dev/stackman:copilot/fix-typos-in-strip-lib-pyCopy head branch name to clipboard
kristjanvalur merged 1 commit into
masterstackless-dev/stackman:masterfrom
copilot/fix-typos-in-strip-lib-pystackless-dev/stackman:copilot/fix-typos-in-strip-lib-pyCopy head branch name to clipboard
Conversation
Agent-Logs-Url: https://github.com/stackless-dev/stackman/sessions/e29ff9b5-da02-4031-9f32-d483cace59d0 Co-authored-by: kristjanvalur <6009543+kristjanvalur@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
kristjanvalur
March 28, 2026 16:50
View session
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Five typos in comments across
tools/strip-lib.py, including two factually incorrect endianness labels.Changes
filed→field,reproducable→reproducible,reproducability→reproducibilityalread→alreadysecond_lm_read: comments on thestruct.unpack("<L", ...)calls saidbig-endian— copy-pasted fromfirst_lm_readwhich genuinely uses>L. The second linker member of a Microsoft.libarchive is little-endian per the PE/COFF spec; the format strings<Lare correct, only the comments were wrong.