Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Skip etcdEncryptionKeyRotation when cluster is hibernated - #173

#173
Merged
ske-prow[bot] merged 1 commit into
ske-v1.145stackitcloud/gardener:ske-v1.145from
etcd-rotation-hibernationstackitcloud/gardener:etcd-rotation-hibernationCopy head branch name to clipboard
Jul 7, 2026
Merged

Skip etcdEncryptionKeyRotation when cluster is hibernated#173
ske-prow[bot] merged 1 commit into
ske-v1.145stackitcloud/gardener:ske-v1.145from
etcd-rotation-hibernationstackitcloud/gardener:etcd-rotation-hibernationCopy head branch name to clipboard

Conversation

@maboehm

@maboehm maboehm commented Jul 7, 2026

Copy link
Copy Markdown

How to categorize this PR?
/area security
/kind bug

What this PR does / why we need it:
etcd key rotation requires the cluster to be awake. So we just skip it if the cluster is hibernated during maintenance.

Which issue(s) this PR fixes:
ref gardener#15200

Special notes for your reviewer:
/cc @stackitcloud/ske-gardener

@ske-prow
ske-prow Bot requested a review from a team July 7, 2026 09:02
@ske-prow ske-prow Bot added the kind/bug Bug label Jul 7, 2026
@ske-prow

ske-prow Bot commented Jul 7, 2026

Copy link
Copy Markdown

@maboehm: The label(s) area/security cannot be applied, because the repository doesn't have them.

Details

In response to this:

How to categorize this PR?
/area security
/kind bug

What this PR does / why we need it:
etcd key rotation requires the cluster to be awake. So we just skip it if the cluster is hibernated during maintenance.

Which issue(s) this PR fixes:
ref gardener#15200

Special notes for your reviewer:
/cc @stackitcloud/ske-gardener

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ske-prow ske-prow Bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 7, 2026
@cerealsnow

cerealsnow commented Jul 7, 2026

Copy link
Copy Markdown

SHIP IT! 🚢🚢
/lgtm

@cerealsnow cerealsnow added the lgtm Indicates that a PR is ready to be merged. label Jul 7, 2026
@maboehm

maboehm commented Jul 7, 2026

Copy link
Copy Markdown
Author

/approve

@ske-prow

ske-prow Bot commented Jul 7, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: maboehm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ske-prow ske-prow Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 7, 2026
@ske-prow
ske-prow Bot merged commit ccfd682 into ske-v1.145 Jul 7, 2026
5 checks passed
@ske-prow
ske-prow Bot deleted the etcd-rotation-hibernation branch July 7, 2026 11:22
ske-prow Bot pushed a commit that referenced this pull request Jul 21, 2026
* Add a jitter to logrotate (#172)

Signed-off-by: Robin Schneider <mail@robinschneider.dev>

* Skip etcdEncryptionKeyRotation when cluster is hibernated (#173)

---------

Signed-off-by: Robin Schneider <mail@robinschneider.dev>
Co-authored-by: Robin Schneider <45321827+robinschneider@users.noreply.github.com>
Co-authored-by: Marcel Boehm <marcel.boehm@inovex.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Bug lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.