Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

docs: add filenames to Marking text examples#409

Merged
AriPerkkio merged 7 commits into
stackblitz:mainstackblitz/tutorialkit:mainfrom
noam-honig:patch-4noam-honig/tutorialkit:patch-4Copy head branch name to clipboard
Nov 8, 2024
Merged

docs: add filenames to Marking text examples#409
AriPerkkio merged 7 commits into
stackblitz:mainstackblitz/tutorialkit:mainfrom
noam-honig:patch-4noam-honig/tutorialkit:patch-4Copy head branch name to clipboard

Conversation

@noam-honig
Copy link
Copy Markdown
Contributor

@noam-honig noam-honig commented Nov 7, 2024

No description provided.

@bolt-new-by-stackblitz
Copy link
Copy Markdown

bolt-new-by-stackblitz Bot commented Nov 7, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

AriPerkkio
AriPerkkio reviewed Nov 7, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@AriPerkkio AriPerkkio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @noam-honig, thanks for the PR.

Though I'm not sure what this is fixing. So it's switching this:

image

Into this:

image

@noam-honig
Copy link
Copy Markdown
Contributor Author

noam-honig commented Nov 7, 2024

@AriPerkkio not exactly, I see my mistake (sorry, I was just editing on github).

The original image confused me - it made me thing the console log should appear twice - I thought it were two examples that are not written correctly.

I fixed it now to be one single example, and also to use title to explain that one is md and the other is code - like other examples in the document.

I hope thats ok

@AriPerkkio
Copy link
Copy Markdown
Contributor

AriPerkkio commented Nov 7, 2024

This is now not aligned with the other example 🤔

tutorialkit/docs/tutorialkit.dev/src/content/docs/guides/creating-content.mdx

Lines 175 to 193 in 8547af7

````md title="content.md"
```js title="code.js" ins={4} del={5} {6} "greeting"
const greeting = 'Hello, World!';
// This is a comment
const added = 'This line was added';
const removed = 'This line was removed';
const highlighted = 'This line is highlighted';
```
````
```js title="code.js" ins={4} del={5} {6} "greeting"
const greeting = 'Hello, World!';
// This is a comment
const added = 'This line was added';
const removed = 'This line was removed';
const highlighted = 'This line is highlighted';
```

@noam-honig
Copy link
Copy Markdown
Contributor Author

noam-honig commented Nov 7, 2024

Sorry - long day and lots of content switching - I hope its ok now

AriPerkkio
AriPerkkio reviewed Nov 8, 2024
View reviewed changes
Comment thread docs/tutorialkit.dev/src/content/docs/guides/creating-content.mdx
AriPerkkio
AriPerkkio reviewed Nov 8, 2024
View reviewed changes
Comment thread docs/tutorialkit.dev/src/content/docs/guides/creating-content.mdx Outdated
AriPerkkio
AriPerkkio approved these changes Nov 8, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@AriPerkkio AriPerkkio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@AriPerkkio AriPerkkio changed the title docs: fixed syntax highlighting of marking text examples docs: add filenames to Marking text examples Nov 8, 2024
@AriPerkkio AriPerkkio merged commit 13b9312 into stackblitz:main Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@AriPerkkio AriPerkkio AriPerkkio approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@noam-honig @AriPerkkio
Morty Proxy This is a proxified and sanitized view of the page, visit original site.