escape quotes in mssql uuid literal renderer - #13449
#13449Closed
dxbjavid wants to merge 1 commit into
sqlalchemy:mainsqlalchemy/sqlalchemy:mainfrom
dxbjavid:mssql-uuid-literal-quotingdxbjavid/sqlalchemy:mssql-uuid-literal-quotingCopy head branch name to clipboard
Closed
escape quotes in mssql uuid literal renderer#13449dxbjavid wants to merge 1 commit intosqlalchemy:mainsqlalchemy/sqlalchemy:mainfrom dxbjavid:mssql-uuid-literal-quotingdxbjavid/sqlalchemy:mssql-uuid-literal-quotingCopy head branch name to clipboard
dxbjavid wants to merge 1 commit into
sqlalchemy:mainsqlalchemy/sqlalchemy:mainfrom
dxbjavid:mssql-uuid-literal-quotingdxbjavid/sqlalchemy:mssql-uuid-literal-quotingCopy head branch name to clipboard
Conversation
Member
|
ive created a general purpose auditing suite to catch all of these at https://gerrit.sqlalchemy.org/c/sqlalchemy/sqlalchemy/+/6843 . this fixes the UUID issue as well as NumericCommon and JSONPATH |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
MSUUid.literal_processorrenders the nativeUNIQUEIDENTIFIERform withreplace("''", "'"), which collapses doubled quotes rather than escaping single ones, so it does the opposite of the genericsqltypes.Uuid.literal_processorit overrides. Withas_uuid=Falsethe value is a plain string rather than aUUIDobject, so a quote inside it ends the rendered literal and the rest is parsed as SQL, both underliteral_bindsand for parameters markedliteral_execute=True, which renders at execution time. Reversing the two arguments toreplace()brings it back in line with the base type; a full example and the before/after output are in #13448.Checklist
This pull request is:
must include a complete example of the issue. one line code fixes without an
issue and demonstration will not be accepted.
Fixes: #<issue number>in the commit messageinclude a complete example of how the feature would look.
Fixes: #<issue number>in the commit messageHave a nice day!