Fix parsing non-protected branches + simplify deserialization#89
Merged
dziemba merged 1 commit intomasterspotify/github-java-client:masterfrom Apr 15, 2022
fix-branch-protection-url-deserializespotify/github-java-client:fix-branch-protection-url-deserializeCopy head branch name to clipboard
Merged
Fix parsing non-protected branches + simplify deserialization#89dziemba merged 1 commit intomasterspotify/github-java-client:masterfrom fix-branch-protection-url-deserializespotify/github-java-client:fix-branch-protection-url-deserializeCopy head branch name to clipboard
dziemba merged 1 commit intomasterspotify/github-java-client:masterfrom
fix-branch-protection-url-deserializespotify/github-java-client:fix-branch-protection-url-deserializeCopy head branch name to clipboard
Conversation
In #82 we added a custom deserializer for the `Branch` class. This deserializer didn't handle certain cases properly that the GH API would return. In particular the case where the `protected` field was set and no `protection_url` is present would lead to a NPE in the deserializer. To avoid this error and make the whole parser more resilient to different API results, let's reduce the scope of the custom deserializer to only parse the `protection_url` field instead of the whole `Branch` class. There should be no change in runtime behavior apart from fixing the error cases.
Codecov Report
@@ Coverage Diff @@
## master #89 +/- ##
============================================
- Coverage 70.20% 69.78% -0.42%
Complexity 222 222
============================================
Files 36 36
Lines 866 854 -12
Branches 36 35 -1
============================================
- Hits 608 596 -12
Misses 233 233
Partials 25 25
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #82 we
added a custom deserializer for the
Branchclass.This deserializer didn't handle certain cases properly that the GH API
would return. In particular the case where the
protectedfield was setand no
protection_urlis present would lead to a NPE in thedeserializer.
To avoid this error and make the whole parser more resilient to
different API results, let's reduce the scope of the custom deserializer
to only parse the
protection_urlfield instead of the wholeBranchclass.
There should be no change in runtime behavior apart from fixing the
error cases.